Make the blocklist more information url https

VERIFIED FIXED in mozilla1.9.2a1

Status

()

VERIFIED FIXED
10 years ago
8 years ago

People

(Reporter: mossop, Assigned: mossop)

Tracking

({verified1.9.1})

Trunk
mozilla1.9.2a1
verified1.9.1
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

10 years ago
Since we are now only warning users about some items we should be reasonably sure that the more information they see is accurate and not spoofed to say something less worrying.
(Assignee)

Comment 1

10 years ago
Created attachment 355384 [details] [diff] [review]
patch rev 1

Simple patch
Assignee: nobody → dtownsend
Status: NEW → ASSIGNED
Attachment #355384 - Flags: review?(robert.bugzilla)
(Assignee)

Comment 2

10 years ago
reed, is using this https url going to be ok? It seems to work to me right now.
https is fine, but it would be preferred if you went ahead and changed it to "https://www.mozilla.com/%LOCALE%/blocklist/". Bug 454300 has a patch to remove the locale subdomain, but it's pending an AMO fix that I'm going to try to get done this week.
(Assignee)

Comment 4

10 years ago
Created attachment 355418 [details] [diff] [review]
patch rev 2

Removes the locale subdomain
Attachment #355384 - Attachment is obsolete: true
Attachment #355418 - Flags: review?(robert.bugzilla)
Attachment #355384 - Flags: review?(robert.bugzilla)
Attachment #355418 - Flags: review?(robert.bugzilla) → review+
(Assignee)

Comment 5

10 years ago
Landed: http://hg.mozilla.org/mozilla-central/rev/6bf12c7664b8
Status: ASSIGNED → RESOLVED
Last Resolved: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.2a1
(Assignee)

Comment 6

10 years ago
Comment on attachment 355418 [details] [diff] [review]
patch rev 2

A minor security win that we might as well take on the branch, no risk
Attachment #355418 - Flags: approval1.9.1?
Attachment #355418 - Flags: approval1.9.1? → approval1.9.1+
(Assignee)

Comment 8

10 years ago
Landed on branch http://hg.mozilla.org/releases/mozilla-1.9.1/rev/273b9ecef4b7
Keywords: fixed1.9.1

Comment 9

10 years ago
Verified fix on Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.1b4) Gecko/20090423 Firefox/3.5b4
and Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.2a1pre) Gecko/20090426 Minefield/3.6a1pre
Status: RESOLVED → VERIFIED
Keywords: fixed1.9.1 → verified1.9.1
Blocks: 597982
You need to log in before you can comment on or make changes to this bug.