Closed Bug 468526 Opened 11 years ago Closed 11 years ago

Make the blocklist more information url https

Categories

(Toolkit :: Add-ons Manager, defect)

defect
Not set

Tracking

()

VERIFIED FIXED
mozilla1.9.2a1

People

(Reporter: mossop, Assigned: mossop)

References

Details

(Keywords: verified1.9.1)

Attachments

(1 file, 1 obsolete file)

Since we are now only warning users about some items we should be reasonably sure that the more information they see is accurate and not spoofed to say something less worrying.
Attached patch patch rev 1 (obsolete) — Splinter Review
Simple patch
Assignee: nobody → dtownsend
Status: NEW → ASSIGNED
Attachment #355384 - Flags: review?(robert.bugzilla)
reed, is using this https url going to be ok? It seems to work to me right now.
https is fine, but it would be preferred if you went ahead and changed it to "https://www.mozilla.com/%LOCALE%/blocklist/". Bug 454300 has a patch to remove the locale subdomain, but it's pending an AMO fix that I'm going to try to get done this week.
Attached patch patch rev 2Splinter Review
Removes the locale subdomain
Attachment #355384 - Attachment is obsolete: true
Attachment #355418 - Flags: review?(robert.bugzilla)
Attachment #355384 - Flags: review?(robert.bugzilla)
Attachment #355418 - Flags: review?(robert.bugzilla) → review+
Landed: http://hg.mozilla.org/mozilla-central/rev/6bf12c7664b8
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.2a1
Comment on attachment 355418 [details] [diff] [review]
patch rev 2

A minor security win that we might as well take on the branch, no risk
Attachment #355418 - Flags: approval1.9.1?
Attachment #355418 - Flags: approval1.9.1? → approval1.9.1+
Verified fix on Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.1b4) Gecko/20090423 Firefox/3.5b4
and Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.2a1pre) Gecko/20090426 Minefield/3.6a1pre
Status: RESOLVED → VERIFIED
Blocks: 597982
You need to log in before you can comment on or make changes to this bug.