454300 - Remove locale-specific subdomains from client-generated URLs

Status: RESOLVED FIXED

(Firefox :: General, defect)

Description

[Stephen Donner [:stephend] Not actively reading bugmail]

Per bug 398938 (this bug would likely have to be fixed first before the
functionality is removed), we should remove the locale-specific subdomains Firefox client-generated URLs.

Comment 1

[Reed Loden [:reed]]

Attachment: patch - v1

Remove %LOCALE% or ${AB_CD} from most URLs used by Firefox.

Places where locale-based subdomains are still used and cannot be removed at present time:
* browser/app/profile/firefox.js -- browser.safebrowsing.provider.0.report*URL
* other-licenses/branding/firefox/locales/browserconfig.properties -- browser.startup.homepage and browser.startup.homepage_reset
* other-licenses/branding/firefox/locales/old-homepage-default.properties -- browser.startup.homepage

Comment 2

[Reed Loden [:reed]]

Attachment: patch - v1.1

unbitrotten version of v1

Comment 3

[Mike Beltzner [:beltzner, not reading bugmail]]

Not blocking unless webdev tells us we need to, but yes, I'd be happy to simplify this.

Comment 4

[:Gavin Sharp [email: [e-mail]]]

13:17 <gavin> are you sure all of the services at those urls are being changed?
13:17 <gavin> (have they already been?)
13:18 <gavin> did you look through each change, or just grep/replace?

Can you provide a list of test urls that cover each service being changed, to show that they work without the locale code?

Comment 5

[Reed Loden [:reed]]

pref("extensions.getAddons.browseAddons", "https://addons.mozilla.org/%LOCALE%/%APP%");
* https://addons.mozilla.org/en-US/firefox

pref("extensions.getAddons.recommended.browseURL", "https://addons.mozilla.org/%LOCALE%/%APP%/recommended");
* https://addons.mozilla.org/en-US/firefox/recommended

pref("extensions.getAddons.search.browseURL", "https://addons.mozilla.org/%LOCALE%/%APP%/search?q=%TERMS%");
* https://addons.mozilla.org/en-US/firefox/search?q=foobar

pref("extensions.blocklist.detailsURL", "http://www.mozilla.com/%LOCALE%/blocklist/");
* http://www.mozilla.com/en-US/blocklist/

pref("browser.dictionaries.download.url", "https://addons.mozilla.org/%LOCALE%/%APP%/%VERSION%/dictionaries/");
* https://addons.mozilla.org/en-US/firefox/3.0.5/dictionaries/

pref("extensions.getMoreExtensionsURL", "https://addons.mozilla.org/%LOCALE%/%APP%/%VERSION%/extensions/");
* https://addons.mozilla.org/en-US/firefox/3.0.5/extensions/

pref("extensions.getMoreThemesURL", "https://addons.mozilla.org/%LOCALE%/%APP%/%VERSION%/themes/");
* https://addons.mozilla.org/en-US/firefox/3.0.5/themes/

pref("extensions.getMorePluginsURL", "https://addons.mozilla.org/%LOCALE%/%APP%/%VERSION%/plugins/");
* https://addons.mozilla.org/en-US/firefox/3.0.5/plugins/

pref("browser.search.searchEnginesURL",      "https://addons.mozilla.org/%LOCALE%/%APP%/%VERSION%/search-engines/");
* https://addons.mozilla.org/en-US/firefox/3.0.5/search-engines/

pref("browser.safebrowsing.warning.infoURL", "http://www.mozilla.com/%LOCALE%/%APP%/phishing-protection/");
* http://www.mozilla.com/en-US/firefox/phishing-protection/

!define URLInfoAbout          "http://www.mozilla.com/${AB_CD}/"
* http://www.mozilla.com/en-US/

!define URLUpdateInfo         "http://www.mozilla.com/${AB_CD}/firefox/"
* http://www.mozilla.com/en-US/firefox/

pref("startup.homepage_override_url","http://www.mozilla.com/%LOCALE%/%APP%/%VERSION%/whatsnew/");
* http://www.mozilla.com/en-US/firefox/3.0.5/whatsnew/

pref("startup.homepage_welcome_url","http://www.mozilla.com/%LOCALE%/%APP%/%VERSION%/firstrun/");
* http://www.mozilla.com/en-US/firefox/3.0.5/firstrun/

pref("app.update.url.manual", "http://www.mozilla.com/%LOCALE%/%APP%/");
* http://www.mozilla.com/en-US/firefox/

pref("app.update.url.details", "http://www.mozilla.com/%LOCALE%/%APP%/releases/");
* http://www.mozilla.com/en-US/firefox/releases/

pref("app.releaseNotesURL", "http://www.mozilla.com/%LOCALE%/%APP%/%VERSION%/releasenotes/");
* http://www.mozilla.com/en-US/firefox/3.0.5/releasenotes/

Comment 6

[Kohei Yoshino [:kohei]]

Note to myself: along with the patch above, we may have to embed ja locale specific URLs into ja/ja-JP-mac builds.

https://ja.add-ons.mozilla.com/ja/ redirects to http://addons.mozilla.jp/ while https://addons.mozilla.org/ja/ does (should) not.

See Bug 427323 for the background info.

Comment 7

[Kohei Yoshino [:kohei]]

(In reply to comment #6)
> Note to myself: along with the patch above, we may have to embed ja locale
> specific URLs into ja/ja-JP-mac builds.
> 
> https://ja.add-ons.mozilla.com/ja/ redirects to http://addons.mozilla.jp/ while
> https://addons.mozilla.org/ja/ does (should) not.

We are discussing this in Bug 505077.

Comment 8

[Reed Loden [:reed]]

Attachment: patch - v2

Comment 9

[Reed Loden [:reed]]

pref("extensions.getAddons.browseAddons", "https://addons.mozilla.org/en-US/firefox");
pref("extensions.getAddons.recommended.browseURL", "https://addons.mozilla.org/en-US/firefox/recommended");
pref("extensions.getAddons.search.browseURL", "https://addons.mozilla.org/en-US/firefox/search?q=%TERMS%");
pref("browser.dictionaries.download.url", "https://addons.mozilla.org/en-US/firefox/dictionaries/");
pref("browser.search.searchEnginesURL",      "https://addons.mozilla.org/en-US/firefox/search-engines/");
pref("browser.safebrowsing.warning.infoURL", "http://www.mozilla.com/en-US/firefox/phishing-protection/");
pref("browser.geolocation.warning.infoURL", "http://www.mozilla.com/en-US/firefox/geolocation/");
 * echo formatURL("https://addons.mozilla.org/en-US/firefox/3.5.4/");
!define URLInfoAbout          "http://www.mozilla.com/en-US/"
!define URLUpdateInfo         "http://www.mozilla.com/en-US/firefox/"
pref("startup.homepage_override_url","http://www.mozilla.com/en-US/firefox/3.5.4/whatsnew/");
pref("startup.homepage_welcome_url","http://www.mozilla.com/en-US/firefox/3.5.4/firstrun/");
pref("app.update.url.manual", "http://www.mozilla.com/en-US/firefox/");
pref("app.update.url.details", "http://www.mozilla.com/en-US/firefox/releases/");
pref("app.releaseNotesURL", "http://www.mozilla.com/en-US/firefox/3.5.4/releasenotes/");

Comment 10

[Reed Loden [:reed]]

http://hg.mozilla.org/mozilla-central/rev/5f761972d745

Comment 11

[Reed Loden [:reed]]

Comment on attachment 413168 [details] [diff] [review]
patch - v2

Requesting approval1.9.2 to this simple patch to remove locale-based subdomains from the various URLs. This allows us to start deprecating these URLs in the future and acts as a tiny perf improvement by not requiring users to go through a redirect.

Comment 12

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 413168 [details] [diff] [review]
patch - v2

a192=beltzner, post-hoc, reed has been scolded and he's begged for the appropriate forgiveness. We'll let him live, for now. ;)

Comment 13

[Stephen Donner [:stephend] Not actively reading bugmail]

Raymond: please ensure your script covers this too; thanks!

Comment 14

[Reed Loden [:reed]]

http://hg.mozilla.org/releases/mozilla-1.9.2/rev/c66829547c12

Comment 15

[Stephen Donner [:stephend] Not actively reading bugmail]

Raymond: do you have this updated in your script, yet?  If so, please send me a new revision so I can land it, and then please mark this as in-testsuite+.  Thanks!