Remove locale-specific subdomains from client-generated URLs

RESOLVED FIXED in Firefox 3.7a1

Status

()

Firefox
General
RESOLVED FIXED
9 years ago
7 years ago

People

(Reporter: stephend, Assigned: reed)

Tracking

Trunk
Firefox 3.7a1
Points:
---
Dependency tree / graph
Bug Flags:
blocking-firefox3.5 -
wanted-firefox3.5 +
wanted1.9.0.x -
wanted1.8.1.x -
in-testsuite ?

Firefox Tracking Flags

(status1.9.2 final-fixed, status1.9.1 wanted)

Details

Attachments

(1 attachment, 2 obsolete attachments)

(Reporter)

Description

9 years ago
Per bug 398938 (this bug would likely have to be fixed first before the
functionality is removed), we should remove the locale-specific subdomains Firefox client-generated URLs.
(Reporter)

Updated

9 years ago
No longer blocks: 398938
(Assignee)

Updated

9 years ago
Assignee: nobody → reed
(Reporter)

Updated

9 years ago
Blocks: 398938
(Assignee)

Comment 1

9 years ago
Created attachment 337549 [details] [diff] [review]
patch - v1

Remove %LOCALE% or ${AB_CD} from most URLs used by Firefox.

Places where locale-based subdomains are still used and cannot be removed at present time:
* browser/app/profile/firefox.js -- browser.safebrowsing.provider.0.report*URL
* other-licenses/branding/firefox/locales/browserconfig.properties -- browser.startup.homepage and browser.startup.homepage_reset
* other-licenses/branding/firefox/locales/old-homepage-default.properties -- browser.startup.homepage
Attachment #337549 - Flags: review?(gavin.sharp)
(Assignee)

Updated

9 years ago
Status: NEW → ASSIGNED
(Assignee)

Updated

9 years ago
Flags: wanted1.9.0.x?
Flags: wanted1.8.1.x?
Flags: wanted-firefox3.1?
Flags: blocking-firefox3.1?
(Assignee)

Comment 2

9 years ago
Created attachment 347475 [details] [diff] [review]
patch - v1.1

unbitrotten version of v1
Attachment #337549 - Attachment is obsolete: true
Attachment #347475 - Flags: review?(gavin.sharp)
Attachment #337549 - Flags: review?(gavin.sharp)
Not blocking unless webdev tells us we need to, but yes, I'd be happy to simplify this.
Flags: wanted-firefox3.1?
Flags: wanted-firefox3.1+
Flags: blocking-firefox3.1?
Flags: blocking-firefox3.1-
Flags: wanted1.9.0.x?
Flags: wanted1.9.0.x-
Flags: wanted1.8.1.x?
Flags: wanted1.8.1.x-
13:17 <gavin> are you sure all of the services at those urls are being changed?
13:17 <gavin> (have they already been?)
13:18 <gavin> did you look through each change, or just grep/replace?

Can you provide a list of test urls that cover each service being changed, to show that they work without the locale code?
(Assignee)

Comment 5

9 years ago
pref("extensions.getAddons.browseAddons", "https://addons.mozilla.org/%LOCALE%/%APP%");
* https://addons.mozilla.org/en-US/firefox

pref("extensions.getAddons.recommended.browseURL", "https://addons.mozilla.org/%LOCALE%/%APP%/recommended");
* https://addons.mozilla.org/en-US/firefox/recommended

pref("extensions.getAddons.search.browseURL", "https://addons.mozilla.org/%LOCALE%/%APP%/search?q=%TERMS%");
* https://addons.mozilla.org/en-US/firefox/search?q=foobar

pref("extensions.blocklist.detailsURL", "http://www.mozilla.com/%LOCALE%/blocklist/");
* http://www.mozilla.com/en-US/blocklist/

pref("browser.dictionaries.download.url", "https://addons.mozilla.org/%LOCALE%/%APP%/%VERSION%/dictionaries/");
* https://addons.mozilla.org/en-US/firefox/3.0.5/dictionaries/

pref("extensions.getMoreExtensionsURL", "https://addons.mozilla.org/%LOCALE%/%APP%/%VERSION%/extensions/");
* https://addons.mozilla.org/en-US/firefox/3.0.5/extensions/

pref("extensions.getMoreThemesURL", "https://addons.mozilla.org/%LOCALE%/%APP%/%VERSION%/themes/");
* https://addons.mozilla.org/en-US/firefox/3.0.5/themes/

pref("extensions.getMorePluginsURL", "https://addons.mozilla.org/%LOCALE%/%APP%/%VERSION%/plugins/");
* https://addons.mozilla.org/en-US/firefox/3.0.5/plugins/

pref("browser.search.searchEnginesURL",      "https://addons.mozilla.org/%LOCALE%/%APP%/%VERSION%/search-engines/");
* https://addons.mozilla.org/en-US/firefox/3.0.5/search-engines/

pref("browser.safebrowsing.warning.infoURL", "http://www.mozilla.com/%LOCALE%/%APP%/phishing-protection/");
* http://www.mozilla.com/en-US/firefox/phishing-protection/

!define URLInfoAbout          "http://www.mozilla.com/${AB_CD}/"
* http://www.mozilla.com/en-US/

!define URLUpdateInfo         "http://www.mozilla.com/${AB_CD}/firefox/"
* http://www.mozilla.com/en-US/firefox/

pref("startup.homepage_override_url","http://www.mozilla.com/%LOCALE%/%APP%/%VERSION%/whatsnew/");
* http://www.mozilla.com/en-US/firefox/3.0.5/whatsnew/

pref("startup.homepage_welcome_url","http://www.mozilla.com/%LOCALE%/%APP%/%VERSION%/firstrun/");
* http://www.mozilla.com/en-US/firefox/3.0.5/firstrun/

pref("app.update.url.manual", "http://www.mozilla.com/%LOCALE%/%APP%/");
* http://www.mozilla.com/en-US/firefox/

pref("app.update.url.details", "http://www.mozilla.com/%LOCALE%/%APP%/releases/");
* http://www.mozilla.com/en-US/firefox/releases/

pref("app.releaseNotesURL", "http://www.mozilla.com/%LOCALE%/%APP%/%VERSION%/releasenotes/");
* http://www.mozilla.com/en-US/firefox/3.0.5/releasenotes/
(Assignee)

Updated

9 years ago
Depends on: 471834
Note to myself: along with the patch above, we may have to embed ja locale specific URLs into ja/ja-JP-mac builds.

https://ja.add-ons.mozilla.com/ja/ redirects to http://addons.mozilla.jp/ while https://addons.mozilla.org/ja/ does (should) not.

See Bug 427323 for the background info.

Updated

8 years ago
Depends on: 505077
(In reply to comment #6)
> Note to myself: along with the patch above, we may have to embed ja locale
> specific URLs into ja/ja-JP-mac builds.
> 
> https://ja.add-ons.mozilla.com/ja/ redirects to http://addons.mozilla.jp/ while
> https://addons.mozilla.org/ja/ does (should) not.

We are discussing this in Bug 505077.
(Assignee)

Comment 8

8 years ago
Created attachment 413168 [details] [diff] [review]
patch - v2
Attachment #347475 - Attachment is obsolete: true
Attachment #413168 - Flags: review?(gavin.sharp)
Attachment #347475 - Flags: review?(gavin.sharp)
(Assignee)

Comment 9

8 years ago
pref("extensions.getAddons.browseAddons", "https://addons.mozilla.org/en-US/firefox");
pref("extensions.getAddons.recommended.browseURL", "https://addons.mozilla.org/en-US/firefox/recommended");
pref("extensions.getAddons.search.browseURL", "https://addons.mozilla.org/en-US/firefox/search?q=%TERMS%");
pref("browser.dictionaries.download.url", "https://addons.mozilla.org/en-US/firefox/dictionaries/");
pref("browser.search.searchEnginesURL",      "https://addons.mozilla.org/en-US/firefox/search-engines/");
pref("browser.safebrowsing.warning.infoURL", "http://www.mozilla.com/en-US/firefox/phishing-protection/");
pref("browser.geolocation.warning.infoURL", "http://www.mozilla.com/en-US/firefox/geolocation/");
 * echo formatURL("https://addons.mozilla.org/en-US/firefox/3.5.4/");
!define URLInfoAbout          "http://www.mozilla.com/en-US/"
!define URLUpdateInfo         "http://www.mozilla.com/en-US/firefox/"
pref("startup.homepage_override_url","http://www.mozilla.com/en-US/firefox/3.5.4/whatsnew/");
pref("startup.homepage_welcome_url","http://www.mozilla.com/en-US/firefox/3.5.4/firstrun/");
pref("app.update.url.manual", "http://www.mozilla.com/en-US/firefox/");
pref("app.update.url.details", "http://www.mozilla.com/en-US/firefox/releases/");
pref("app.releaseNotesURL", "http://www.mozilla.com/en-US/firefox/3.5.4/releasenotes/");
Attachment #413168 - Flags: review?(gavin.sharp) → review+
(Assignee)

Comment 10

8 years ago
http://hg.mozilla.org/mozilla-central/rev/5f761972d745
Status: ASSIGNED → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 3.7a1
(Assignee)

Updated

8 years ago
Whiteboard: [baking on trunk since 2009-12-03]
(Assignee)

Comment 11

8 years ago
Comment on attachment 413168 [details] [diff] [review]
patch - v2

Requesting approval1.9.2 to this simple patch to remove locale-based subdomains from the various URLs. This allows us to start deprecating these URLs in the future and acts as a tiny perf improvement by not requiring users to go through a redirect.
Attachment #413168 - Flags: approval1.9.2?

Updated

8 years ago
Blocks: 532644
Blocks: 497072
Comment on attachment 413168 [details] [diff] [review]
patch - v2

a192=beltzner, post-hoc, reed has been scolded and he's begged for the appropriate forgiveness. We'll let him live, for now. ;)
Attachment #413168 - Flags: approval1.9.2? → approval1.9.2+

Updated

8 years ago
No longer blocks: 532644
(Reporter)

Comment 13

8 years ago
Raymond: please ensure your script covers this too; thanks!
Flags: in-testsuite?
(Assignee)

Comment 14

8 years ago
http://hg.mozilla.org/releases/mozilla-1.9.2/rev/c66829547c12
status1.9.2: --- → final-fixed
(Assignee)

Updated

8 years ago
Whiteboard: [baking on trunk since 2009-12-03]
(Assignee)

Updated

8 years ago
status1.9.2: beta5-fixed → final-fixed
(Reporter)

Comment 15

8 years ago
Raymond: do you have this updated in your script, yet?  If so, please send me a new revision so I can land it, and then please mark this as in-testsuite+.  Thanks!
blocking1.9.1: --- → ?
status1.9.1: --- → ?
blocking1.9.1: ? → ---
status1.9.1: ? → wanted
Blocks: 597985
You need to log in before you can comment on or make changes to this bug.