468552 - "ASSERTION: hmm? CanCallNow failed in XPCWrappedNative::CallMethod. We are finding out about this late!" messing with __proto__, XPCNativeWrapper

Status: VERIFIED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Jesse Ruderman]

Attachment: testcase

###!!! ASSERTION: hmm? CanCallNow failed in XPCWrappedNative::CallMethod. We are finding out about this late!: 'rv == NS_ERROR_XPC_SECURITY_MANAGER_VETO', file /Users/jruderman/central/js/src/xpconnect/src/xpcwrappednative.cpp, line 1935

Comment 1

[Blake Kaplan (:mrbkap) (inactive)]

Attachment: Fix

This is the easiest way to fix this. The problem is that we don't bother enforcing the funobj checks.

Comment 2

[Blake Kaplan (:mrbkap) (inactive)]

http://hg.mozilla.org/mozilla-central/rev/72d890672053

Comment 3

[Johnny Stenback (:jst)]

Comment on attachment 352455 [details] [diff] [review]
Fix

Taking this on the branch is a good thing to do, and it makes Blake's life easier, so a=jst

Comment 4

[Blake Kaplan (:mrbkap) (inactive)]

http://hg.mozilla.org/releases/mozilla-1.9.1/rev/61beb1b0e247 contains the fix for this on the 1.9.1 branch.

Comment 5

[Aakash Desai [:aakashd]]

verified FIXED on debug builds:


Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.1pre) Gecko/20090608 Shiretoko/3.5pre ID:20090608122057

and

Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.2a1pre) Gecko/20090608 Minefield/3.6a1pre ID:20090608122028