471366 - Crash [@ XPCWrappedNative::GetFlatJSObject] with ({__proto__: XPCNativeWrapper.prototype})

Status: VERIFIED FIXED

(Core :: XPConnect, defect)

Description

[Jesse Ruderman]

Attachment: testcase (crashes Firefox when loaded)

Comment 1

[Jim Blandy :jimb]

This looks related to bug 454704.

Comment 2

[Jim Blandy :jimb]

Got any more details than "when loaded"?  I've got a Firefox here with around 30 tabs open (mostly bugzilla), and it doesn't crash for me.

Comment 3

[Jesse Ruderman]

It crashes immediately for me.

Comment 4

[Jim Blandy :jimb]

Ahh, yes.  Immediate segfault for me as well, on Linux.

Comment 5

[Blake Kaplan (:mrbkap) (inactive)]

Oops, my fault from bug 468552. Sorry for stealing, jimb.

Comment 6

[Blake Kaplan (:mrbkap) (inactive)]

Attachment: Fix

If there's no wrapped native in the native wrapper, we should just continue looking up the prototype chain (in practice this means that we'll just bail out).

Comment 7

[Blake Kaplan (:mrbkap) (inactive)]

http://hg.mozilla.org/mozilla-central/rev/fa32dcbc72b7

Comment 8

[Ashley Bischoff (blog at handcoding.com)]

Is there any chance this checkin may have caused bug 472674? Greasemonkey stopped working in the 20090106155755 build and we're trying to narrow things down. 

(One of the other suspects is bug 470720, but that one is security-restricted.)

Comment 9

[Blake Kaplan (:mrbkap) (inactive)]

Alex, the culprit is bug 470720.

Comment 10

[Dão Gottwald [:dao]]

http://hg.mozilla.org/releases/mozilla-1.9.1/rev/61beb1b0e247

Comment 11

[Brian Crowder]

Why does this depend on the greasemonkey error bug?

Comment 12

[Aakash Desai [:aakashd]]

verified FIXED on builds: 
Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.2a1pre) Gecko/20090421 Minefield/3.6a1pre ID:20090421032809

and

Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.1b4pre) Gecko/20090421 Shiretoko/3.5b4pre ID:20090421030848