468754 - getItemIdForGUID ignores anno name

Status: RESOLVED INVALID

(Firefox :: Bookmarks & History, defect)

Description

[Dan Mills [:thunder]]

The mDBGetItemIdForGUID SQL statement:

http://mxr.mozilla.org/mozilla-central/source/toolkit/components/places/src/nsNavBookmarks.cpp#295

Does not use the guid anno name ("placesInternal/GUID").  Seems to me this could return other items which have a different anno with the same value.

Of course, that is unlikely, but possible given some hypothetical extension that saves e.g., "myext/related" with the value being a related GUID.

Comment 1

[Gervase Markham [:gerv]]

Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv

Comment 2

[Saint Wesonga]

Attachment: Patch

Comment 4

[Saint Wesonga]

Comment on attachment 451660 [details] [diff] [review]
Patch

let me see if I can compose a test for this...

Comment 5

[Marco Bonardo [:mak]]

you should use the GUID_ANNO macro. Yes, the test should not be too hard to do.

Comment 6

[Marco Bonardo [:mak]]

this API died quite some time ago