468860 - class="plain" should turn off -moz-appearance too

Status: RESOLVED FIXED

(Toolkit :: Themes, defect)

Description

[[e-mail]]

When class="plain" was invented it only turned off margin, borders and padding because -moz-appearance hadn't been invented yet. Now that we've added -moz-appearance to everything do we need class="plain" to turn that off too?

I also noticed that we have some (but not all) duplication between global.css button.css and textbox.css which we could eliminate at the same time.

Pinstripe would probably have to be dealt with separately.

Comment 1

[Markus Stange [:mstange]]

Yeah, Pinstripe doesn't even use -moz-appearance for trees.

Comment 2

[Neil Deakin]

The plain class was intended originally only for labels which don't have native theming, as well as buttons and textboxes. It would be good however to have it apply to all elements however, so we should do this.

> Pinstripe would probably have to be dealt with separately.

Why?

Comment 3

[[e-mail]]

(In reply to comment #2)
> The plain class was intended originally only for labels which don't have native
> theming, as well as buttons and textboxes. It would be good however to have it
> apply to all elements however, so we should do this.
In fact it does apply to all elements, via the rule in global.css, although textboxes additionally apply -moz-appearance: none; to their copy.

> > Pinstripe would probably have to be dealt with separately.
> Why?
Sorry, I misread its button.css; there are no borders for it to override.

Comment 4

[Markus Stange [:mstange]]

Attachment: just do it

Is there any reason to not just do this?

Comment 5

[[e-mail]]

Comment on attachment 391798 [details] [diff] [review]
just do it

Let's give it a whirl ;-)

Comment 6

[[e-mail]]

I guess we then need to look for places that emulate plain e.g. #downloadView

Comment 7

[Markus Stange [:mstange]]

(In reply to comment #6)
> I guess we then need to look for places that emulate plain e.g. #downloadView

Bug 426917 says that on windows classic #downloadView shouldn't be plain.

Comment 8

[Markus Stange [:mstange]]

http://hg.mozilla.org/mozilla-central/rev/0cd13b752ef9