469052 - Message and Folder move/copy/delete operations should be shown on the Activity Manager window

Status: RESOLVED FIXED

(Thunderbird :: General, defect)

Description

[Emre Birol]

These operations should be represented to the user in form of activity manager events with a possibility of undo.

Comment 1

[Emre Birol]

Attachment: Take 1

Mostly done. Undo issue needs to be solved. Waiting for activity manager to be completed before submitting the final cut.

Work in progress.

Comment 2

[David Ascher (:davida)]

Wanted, but would not block.

Comment 3

[David Ascher (:davida)]

Revised version folded into the patch for bug 469053.

Comment 4

[David Ascher (:davida)]

Attachment: proposed patch

This new module system is nice!

Comment 5

[David Ascher (:davida)]

Attachment: oops

one leftover from the sendlater copy & paste, now removed.

Comment 6

[Mark Banner (:standard8)]

Comment on attachment 361677 [details] [diff] [review]
oops

A quick look and this seems reasonable, I've pushed it already: http://hg.mozilla.org/comm-central/rev/d2019dbd19c3

Comment 7

[David Ascher (:davida)]

I think this means we can close this bug.  New bugs w/ the feature should be placed in new bugs.

Testing note: this won't be testable until 476700 is resolved.

Once that is done, however, users should be able to: move, delete, copy messages and folders, as well as rename folders, and see those actions reflected in the activity manager window.  Particular code paths that would be good to have in the tests include: 

 - 1 vs. many messages; 
 - move and copy;
 - moves and copies across accounts; renames including weird characters.

I'm hoping that i'm setting the right litmus flag.

Comment 8

[Thomas Stache]

One thing that doesn't seem quite right is that message deletes are listed as "Moved from ... to <mail.server...trash_folder_name>"
(IMAP server, option "when i delete a message:" set to "move it to this folder: ...").

Comment 9

[Ludovic Hirlimann [:Usul]]

9514,9515,9516,9517 have beend added to FFT.