Closed
Bug 469112
Opened 16 years ago
Closed 16 years ago
Provide tests for Bug 463504
Categories
(SeaMonkey :: Security, defect)
SeaMonkey
Security
Tracking
(Not tracked)
RESOLVED
FIXED
seamonkey2.0a3
People
(Reporter: misak.bugzilla, Assigned: misak.bugzilla)
References
Details
Attachments
(1 file, 2 obsolete files)
|
4.32 KB,
patch
|
Details | Diff | Splinter Review |
I forgot to add tests in Bug 463504 patch.
|
Assignee | |
Comment 1•16 years ago
|
||
Test for cert error page. I ran it, it passes on my linux. However test file placement maybe wrong. I need suggestions here.
Attachment #352528 -
Flags: review?(neil)
|
||
Comment 2•16 years ago
|
||
Comment on attachment 352528 [details] [diff] [review]
patch v1
I guess as we only have the two tests it's not worth putting them in their own directory yet ;-)
Attachment #352528 -
Flags: review?(neil) → review+
|
|
Assignee | |
Comment 3•16 years ago
|
||
Taking into account that sessionstore patch will introduce 21 browser test files, better to have dedicated directory.
Attachment #352528 -
Attachment is obsolete: true
Attachment #352545 -
Flags: superreview?(neil)
Attachment #352545 -
Flags: review?(neil)
|
|
||
Comment 4•16 years ago
|
||
Comment on attachment 352545 [details] [diff] [review]
v2
warning: 8 lines add whitespace errors.
>+DIRS = \
>+ browser \
>+ chrome \
>+ $(NULL)
Nit: could use PARALLEL_DIRS here.
Attachment #352545 -
Flags: superreview?(neil)
Attachment #352545 -
Flags: superreview+
Attachment #352545 -
Flags: review?(neil)
Attachment #352545 -
Flags: review+
|
|
Assignee | |
Comment 5•16 years ago
|
||
carrying r+, sr+ from Neil
Attachment #352545 -
Attachment is obsolete: true
|
|
Assignee | |
Updated•16 years ago
|
Keywords: checkin-needed
|
||
Updated•16 years ago
|
Attachment #352552 -
Attachment description: for checkin. nits fixed → for checkin. nits fixed
[Checkin: Comment 6]
|
|
||
Comment 6•16 years ago
|
||
Comment on attachment 352552 [details] [diff] [review]
for checkin. nits fixed
[Checkin: Comment 6]
http://hg.mozilla.org/comm-central/rev/68fc7a23afc8
|
|
||
Updated•16 years ago
|
Assignee: nobody → misak
Status: NEW → RESOLVED
Closed: 16 years ago
Component: General → Security
Depends on: 463504
Flags: in-testsuite+
Keywords: checkin-needed
QA Contact: general → seamonkey
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.0a3
You need to log in
before you can comment on or make changes to this bug.
Description
•