Last Comment Bug 533176 - Port |Bug 425001 - Tests for bug 400731, 431826 use timers, are fragile| to SeaMonkey
: Port |Bug 425001 - Tests for bug 400731, 431826 use timers, are fragile| to S...
Status: RESOLVED FIXED
: fixed-seamonkey2.0.3
Product: SeaMonkey
Classification: Client Software
Component: Security (show other bugs)
: Trunk
: All All
: -- minor (vote)
: seamonkey2.1a1
Assigned To: Serge Gautherie (:sgautherie)
:
Mentors:
Depends on: 425001 469112
Blocks: 533210 152526
  Show dependency treegraph
 
Reported: 2009-12-06 10:16 PST by Serge Gautherie (:sgautherie)
Modified: 2009-12-07 17:23 PST (History)
0 users
bugzillamozillaorg_serge_20140323: in‑testsuite+
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---


Attachments
(Av1) Port m-c browser_bug431826.js changes to c-c browser_bug463504.js [Checkin: Comment 5 & 8] (2.46 KB, patch)
2009-12-06 17:00 PST, Serge Gautherie (:sgautherie)
neil: review+
kairo: approval‑seamonkey2.0.1-
kairo: approval‑seamonkey2.0.3+
Details | Diff | Splinter Review
(Bv1) /setTimeout(,0)/executeSoon()/g in /suite/* tests [Checkin: Comment 6+10 & 9+10] (5.11 KB, patch)
2009-12-06 17:27 PST, Serge Gautherie (:sgautherie)
neil: review+
kairo: approval‑seamonkey2.0.3+
Details | Diff | Splinter Review

Description Serge Gautherie (:sgautherie) 2009-12-06 10:16:55 PST

    
Comment 1 Serge Gautherie (:sgautherie) 2009-12-06 17:00:59 PST
Created attachment 416371 [details] [diff] [review]
(Av1) Port m-c browser_bug431826.js changes to c-c browser_bug463504.js
[Checkin: Comment 5 & 8]

This fixes bug 152526 perma-orange on (my) Windows SM 2.0.x.
(At least when running the whole /suite/*.
I could make this test fail/regress when running fewer selected tests only: I'll post a workaround I have for that if need be, but I prefer to leave this "unrelated" issue for later...)

"approval-seamonkey2.0.1=?":
No risk, test only, to help get green waterfall on 2.0.1 (and 2.0.2+).
Comment 2 Serge Gautherie (:sgautherie) 2009-12-06 17:27:08 PST
Created attachment 416372 [details] [diff] [review]
(Bv1) /setTimeout(,0)/executeSoon()/g in /suite/* tests
[Checkin: Comment 6+10 & 9+10]

While there, just improve these too.
http://mxr.mozilla.org/comm-central/search?string=setTimeout&case=on&find=%2Fsuite%2F.*test
Comment 3 Serge Gautherie (:sgautherie) 2009-12-06 17:29:52 PST
Comment on attachment 416372 [details] [diff] [review]
(Bv1) /setTimeout(,0)/executeSoon()/g in /suite/* tests
[Checkin: Comment 6+10 & 9+10]


"approval-seamonkey2.0.2=?":
No risk, test only.
Comment 4 neil@parkwaycc.co.uk 2009-12-07 02:29:43 PST
Comment on attachment 416371 [details] [diff] [review]
(Av1) Port m-c browser_bug431826.js changes to c-c browser_bug463504.js
[Checkin: Comment 5 & 8]

Doesn't make a lot of difference, but I'd have thought (assuming it works) that newBrowser would have been better than window.
Comment 5 Serge Gautherie (:sgautherie) 2009-12-07 03:09:07 PST
Comment on attachment 416371 [details] [diff] [review]
(Av1) Port m-c browser_bug431826.js changes to c-c browser_bug463504.js
[Checkin: Comment 5 & 8]


http://hg.mozilla.org/comm-central/rev/328293ec27b7

(In reply to comment #4)

Self-answered in bug 533210 comment 2.
Comment 6 Serge Gautherie (:sgautherie) 2009-12-07 03:10:19 PST
Comment on attachment 416372 [details] [diff] [review]
(Bv1) /setTimeout(,0)/executeSoon()/g in /suite/* tests
[Checkin: Comment 6+10 & 9+10]


http://hg.mozilla.org/comm-central/rev/d74dc8ab4f13
Comment 7 Robert Kaiser 2009-12-07 11:50:34 PST
Comment on attachment 416371 [details] [diff] [review]
(Av1) Port m-c browser_bug431826.js changes to c-c browser_bug463504.js
[Checkin: Comment 5 & 8]

2.0.1 has been cut, but a=me for 2.0.2
Comment 8 Serge Gautherie (:sgautherie) 2009-12-07 13:12:06 PST
Comment on attachment 416371 [details] [diff] [review]
(Av1) Port m-c browser_bug431826.js changes to c-c browser_bug463504.js
[Checkin: Comment 5 & 8]


http://hg.mozilla.org/releases/comm-1.9.1/rev/b7f1a3f11318
Comment 9 Serge Gautherie (:sgautherie) 2009-12-07 13:12:23 PST
Comment on attachment 416372 [details] [diff] [review]
(Bv1) /setTimeout(,0)/executeSoon()/g in /suite/* tests
[Checkin: Comment 6+10 & 9+10]


http://hg.mozilla.org/releases/comm-1.9.1/rev/35e57bd09de4
Comment 10 Serge Gautherie (:sgautherie) 2009-12-07 17:16:04 PST
Comment on attachment 416372 [details] [diff] [review]
(Bv1) /setTimeout(,0)/executeSoon()/g in /suite/* tests
[Checkin: Comment 6+10 & 9+10]


(Cv1) /setTimeout(,0)/executeSoon()/g in /suite/* tests ... bustage fix, my bad :-<

http://hg.mozilla.org/comm-central/rev/e29bae488b4d
http://hg.mozilla.org/releases/comm-1.9.1/rev/dbcf7278d19a
Comment 11 Serge Gautherie (:sgautherie) 2009-12-07 17:23:08 PST
(In reply to comment #10)
> (Cv1) /setTimeout(,0)/executeSoon()/g in /suite/* tests ... bustage fix, my bad
> :-<

Ftr, there was
{
TEST-UNEXPECTED-FAIL | chrome://mochikit/content/browser/suite/browser/test/browser_bug462289.js | mouse on tab selects tab - Got [object XULElement], expected [object XULElement]
TEST-UNEXPECTED-FAIL | chrome://mochikit/content/browser/suite/browser/test/browser_bug462289.js | mouse on tab while focused still activeElement - Got [object XULElement], expected [object XULElement]
TEST-UNEXPECTED-FAIL | chrome://mochikit/content/browser/suite/browser/test/browser_bug462289.js | mouse on another tab while focused still activeElement - Got [object XULElement], expected [object XULElement]
}

Note You need to log in before you can comment on or make changes to this bug.