The default bug view has changed. See this FAQ.

Port |Bug 425001 - Tests for bug 400731, 431826 use timers, are fragile| to SeaMonkey

RESOLVED FIXED in seamonkey2.1a1

Status

SeaMonkey
Security
--
minor
RESOLVED FIXED
7 years ago
7 years ago

People

(Reporter: sgautherie, Assigned: sgautherie)

Tracking

(Blocks: 1 bug, {fixed-seamonkey2.0.3})

Trunk
seamonkey2.1a1
fixed-seamonkey2.0.3
Dependency tree / graph
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

Comment hidden (empty)
(Assignee)

Updated

7 years ago
Blocks: 152526
(Assignee)

Updated

7 years ago
Depends on: 533210
(Assignee)

Updated

7 years ago
Blocks: 533210
No longer depends on: 533210
(Assignee)

Comment 1

7 years ago
Created attachment 416371 [details] [diff] [review]
(Av1) Port m-c browser_bug431826.js changes to c-c browser_bug463504.js
[Checkin: Comment 5 & 8]

This fixes bug 152526 perma-orange on (my) Windows SM 2.0.x.
(At least when running the whole /suite/*.
I could make this test fail/regress when running fewer selected tests only: I'll post a workaround I have for that if need be, but I prefer to leave this "unrelated" issue for later...)

"approval-seamonkey2.0.1=?":
No risk, test only, to help get green waterfall on 2.0.1 (and 2.0.2+).
Attachment #416371 - Flags: review?(neil)
Attachment #416371 - Flags: approval-seamonkey2.0.1?
(Assignee)

Comment 2

7 years ago
Created attachment 416372 [details] [diff] [review]
(Bv1) /setTimeout(,0)/executeSoon()/g in /suite/* tests
[Checkin: Comment 6+10 & 9+10]

While there, just improve these too.
http://mxr.mozilla.org/comm-central/search?string=setTimeout&case=on&find=%2Fsuite%2F.*test
Attachment #416372 - Flags: review?(neil)
(Assignee)

Comment 3

7 years ago
Comment on attachment 416372 [details] [diff] [review]
(Bv1) /setTimeout(,0)/executeSoon()/g in /suite/* tests
[Checkin: Comment 6+10 & 9+10]


"approval-seamonkey2.0.2=?":
No risk, test only.
Attachment #416372 - Flags: approval-seamonkey2.0.2?

Comment 4

7 years ago
Comment on attachment 416371 [details] [diff] [review]
(Av1) Port m-c browser_bug431826.js changes to c-c browser_bug463504.js
[Checkin: Comment 5 & 8]

Doesn't make a lot of difference, but I'd have thought (assuming it works) that newBrowser would have been better than window.
Attachment #416371 - Flags: review?(neil) → review+

Updated

7 years ago
Attachment #416372 - Flags: review?(neil) → review+
(Assignee)

Comment 5

7 years ago
Comment on attachment 416371 [details] [diff] [review]
(Av1) Port m-c browser_bug431826.js changes to c-c browser_bug463504.js
[Checkin: Comment 5 & 8]


http://hg.mozilla.org/comm-central/rev/328293ec27b7

(In reply to comment #4)

Self-answered in bug 533210 comment 2.
Attachment #416371 - Attachment description: (Av1) Port m-c browser_bug431826.js changes to c-c browser_bug463504.js → (Av1) Port m-c browser_bug431826.js changes to c-c browser_bug463504.js [Checkin: Comment 5]
(Assignee)

Comment 6

7 years ago
Comment on attachment 416372 [details] [diff] [review]
(Bv1) /setTimeout(,0)/executeSoon()/g in /suite/* tests
[Checkin: Comment 6+10 & 9+10]


http://hg.mozilla.org/comm-central/rev/d74dc8ab4f13
Attachment #416372 - Attachment description: (Bv1) /setTimeout(,0)/executeSoon()/g in /suite/* tests. → (Bv1) /setTimeout(,0)/executeSoon()/g in /suite/* tests [Checkin: Comment 6]
(Assignee)

Updated

7 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 7 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.1a1

Comment 7

7 years ago
Comment on attachment 416371 [details] [diff] [review]
(Av1) Port m-c browser_bug431826.js changes to c-c browser_bug463504.js
[Checkin: Comment 5 & 8]

2.0.1 has been cut, but a=me for 2.0.2
Attachment #416371 - Flags: approval-seamonkey2.0.2+
Attachment #416371 - Flags: approval-seamonkey2.0.1?
Attachment #416371 - Flags: approval-seamonkey2.0.1-

Updated

7 years ago
Attachment #416372 - Flags: approval-seamonkey2.0.2? → approval-seamonkey2.0.2+
(Assignee)

Comment 8

7 years ago
Comment on attachment 416371 [details] [diff] [review]
(Av1) Port m-c browser_bug431826.js changes to c-c browser_bug463504.js
[Checkin: Comment 5 & 8]


http://hg.mozilla.org/releases/comm-1.9.1/rev/b7f1a3f11318
Attachment #416371 - Attachment description: (Av1) Port m-c browser_bug431826.js changes to c-c browser_bug463504.js [Checkin: Comment 5] → (Av1) Port m-c browser_bug431826.js changes to c-c browser_bug463504.js [Checkin: Comment 5 & 8]
(Assignee)

Comment 9

7 years ago
Comment on attachment 416372 [details] [diff] [review]
(Bv1) /setTimeout(,0)/executeSoon()/g in /suite/* tests
[Checkin: Comment 6+10 & 9+10]


http://hg.mozilla.org/releases/comm-1.9.1/rev/35e57bd09de4
Attachment #416372 - Attachment description: (Bv1) /setTimeout(,0)/executeSoon()/g in /suite/* tests [Checkin: Comment 6] → (Bv1) /setTimeout(,0)/executeSoon()/g in /suite/* tests [Checkin: Comment 6 & 9]
(Assignee)

Updated

7 years ago
Keywords: fixed-seamonkey2.0.2
(Assignee)

Comment 10

7 years ago
Comment on attachment 416372 [details] [diff] [review]
(Bv1) /setTimeout(,0)/executeSoon()/g in /suite/* tests
[Checkin: Comment 6+10 & 9+10]


(Cv1) /setTimeout(,0)/executeSoon()/g in /suite/* tests ... bustage fix, my bad :-<

http://hg.mozilla.org/comm-central/rev/e29bae488b4d
http://hg.mozilla.org/releases/comm-1.9.1/rev/dbcf7278d19a
Attachment #416372 - Attachment description: (Bv1) /setTimeout(,0)/executeSoon()/g in /suite/* tests [Checkin: Comment 6 & 9] → (Bv1) /setTimeout(,0)/executeSoon()/g in /suite/* tests [Checkin: Comment 6+10 & 9+10]
(Assignee)

Comment 11

7 years ago
(In reply to comment #10)
> (Cv1) /setTimeout(,0)/executeSoon()/g in /suite/* tests ... bustage fix, my bad
> :-<

Ftr, there was
{
TEST-UNEXPECTED-FAIL | chrome://mochikit/content/browser/suite/browser/test/browser_bug462289.js | mouse on tab selects tab - Got [object XULElement], expected [object XULElement]
TEST-UNEXPECTED-FAIL | chrome://mochikit/content/browser/suite/browser/test/browser_bug462289.js | mouse on tab while focused still activeElement - Got [object XULElement], expected [object XULElement]
TEST-UNEXPECTED-FAIL | chrome://mochikit/content/browser/suite/browser/test/browser_bug462289.js | mouse on another tab while focused still activeElement - Got [object XULElement], expected [object XULElement]
}
You need to log in before you can comment on or make changes to this bug.