Closed Bug 469231 Opened 16 years ago Closed 15 years ago

new message headers arriving in folders sometimes not displayed

Categories

(MailNews Core :: Database, defect, P1)

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 3.0b2

People

(Reporter: davida, Assigned: Bienvenu)

Details

(Whiteboard: [no l10n impact])

Attachments

(2 files)

I have TB trunk take bugmail and put it in a special bugmail folder.

With that scenario, it happens that I get notifications (in particular folder pane folder showing bold numbers) about messages in the bugmail folder (good).

I think click on the bugmail folder, but the headers aren't there yet.  Hitting space then asks whether I want to move to the next folder.  (both of those are bad).

Bienvenu thinks that the filter code is somehow notifying the target folder of the presence of new messages but not the specific headers.

This happens w/ saved searches as well.
Flags: blocking-thunderbird3?
I have virtually the same symptoms. Im my case, it is my newsgroup m.d.a.thunderbird which is constantly getting a false notification, so that it almost always shows one more message than it actually has. Click on the folder, it clears, but within minutes it is back to showing one unread message (falsely).

I've been meaning to trace it out.
parallel to 
  Bug 166342 - next unread news does nothing if all messages are read and a new one arrives
   Bug 264595 - 'n' command (Go to next unread message) won't open multiple levels of folders
davida was complaining about this recently (or something very similar, but basically the issue has to do with not seeing a new message right after the message is moved to the folder). Because of the way some imap servers don't keep connections completely in sync, there can be a delay when connection 1 moves a message from folder 1 to folder 2, if connection 2 is already open on folder 2. 
But davida said this felt like something that used to work, so I will investigate.
Flags: blocking-thunderbird3? → blocking-thunderbird3+
Target Milestone: --- → Thunderbird 3.0b3
Attached patch proposed fixSplinter Review
in some cases, these new messages don't appear to be part of threads yet - but we shouldn't assume them to be part of killed threads in that case. This fixes the issue where you move a message to a folder, and then click on the folder, and don't see the message right away. I'll try to figure out why they're not parts of threads yet, but this should help quite a bit.
Attachment #359421 - Flags: superreview?(bugzilla)
Attachment #359421 - Flags: review?(bugzilla)
Comment on attachment 359421 [details] [diff] [review]
proposed fix

it turns out that the thread we're getting back from GetThreadContainingMsgHdr is not the same object as the actual thread that we're adding the message to, so it has a child count of 0 - we're finding it from the cached thread object in the db. I'll have to figure out why it's different...but I still think we shouldn't be assuming the hdr is killed...
this fixes the thread issue by caching the new thread - I think both patches are the right thing to do, however.
Attachment #359440 - Flags: superreview?(bugzilla)
Attachment #359440 - Flags: review?(bugzilla)
Standard8, I'm curious what your experience with bug 359339 is with these patches and the patches for that bug applied. I don't know why it would help with the disappearing problem but I don't really understand that problem. I'm pretty sure it should help with the delayed appearance of the messages.
now that I understand the problem, changing summary and blocking b2
Summary: Filters mess with notifications → new message headers arriving in folders sometimes not displayed
Target Milestone: Thunderbird 3.0b3 → Thunderbird 3.0b2
Assignee: bienvenu → nobody
Component: Filters → Database
Priority: -- → P1
QA Contact: filters → database
Whiteboard: has patch for review
Assignee: nobody → bienvenu
Status: NEW → ASSIGNED
Whiteboard: has patch for review → [has patch for review][no l10n impact]
Attachment #359440 - Flags: superreview?(bugzilla)
Attachment #359440 - Flags: superreview+
Attachment #359440 - Flags: review?(bugzilla)
Attachment #359440 - Flags: review+
Attachment #359421 - Flags: superreview?(bugzilla)
Attachment #359421 - Flags: superreview+
Attachment #359421 - Flags: review?(bugzilla)
Attachment #359421 - Flags: review+
Whiteboard: [has patch for review][no l10n impact] → [no l10n impact]
both patches landed.
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.