Closed Bug 469396 Opened 16 years ago Closed 16 years ago

Don't re-read version.txt when we can just use MOZ_APP_VERSION

Categories

(Thunderbird :: Build Config, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 3.0b2

People

(Reporter: standard8, Assigned: standard8)

Details

Attachments

(1 file)

Attached patch The fixSplinter Review
In mail/app/Makefile.in and mail/locales/Makefile.in we're re-reading the application version from version.txt rather than just using the MOZ_APP_VERSION which is already defined for us (via confvars.sh).

We should therefore change this as a) it'll remove 2 file reads in the build process, and b) it'll make implementing a version switch for mozilla-central versus mozilla-1.9.1 easier (I'm planning on adding a second version.txt file).
Attachment #352790 - Flags: review?(gozer)
Attachment #352790 - Flags: review?(gozer) → review+
Comment on attachment 352790 [details] [diff] [review]
The fix

It looks indeed redundant, and will save 2 shell+cat invocations. Works for me.
Checked in http://hg.mozilla.org/comm-central/rev/c9bac99ecba9
Status: NEW → RESOLVED
Closed: 16 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.