469550 - Migrate mozilla/tools/buildbotcustom and mozilla/tools/buildbot to hg

Status: VERIFIED FIXED

(Release Engineering :: General, enhancement, P3)

Description

[Serge Gautherie (:sgautherie)]

I couldn't find these directories in "any" Hg repositories.
Working thru cvs is not wanted anymore.

If moving the whole "process" from cvs to Hg is unwanted atm,
it would yet be much better to have at least an Hg mirror.

Possible places where it could go, I think:
http://hg.mozilla.org/cvs-trunk-mirror/file/default/tools/
http://hg.mozilla.org/build/tools/file/default
http://hg.mozilla.org/mozilla-central/file/default/tools/
elsewhere...

Comment 1

[Nick Thomas [:nthomas] (UTC+12)]

IMO, a mirror creates complexity than benefit.

Comment 2

[[e-mail] (:bhearsum)]

Totally agree with Nick here. We will move this module to Mercurial at some point, no mirror in the meantime.

Comment 3

[[e-mail] (:bhearsum)]

I will be doing this in Q1.

Comment 4

[Chris Cooper [:coop] (he/him)]

Reassigning based on comment #3.

Comment 5

[[e-mail] (:bhearsum)]

(Adding mozilla/tools/buildbot to this because I may as well, while I'm doing buildbotcustom.)

I posted to mozilla.dev.builds about a plan/timeline for this. Here's the specifics (assuming no one has objections):
* Import both of these modules to Mercurial repositories, with history
* Update checkouts on Buildbot masters to clone the new repositories
* Delete mozilla/tools/buildbotcustom and mozilla/tools/buildbot from CVS on Friday, January 30th

Note that our build slaves will still have checkouts of the CVS mozilla/tools/buildbot when this is done. The next we do a Buildbot version upgrade we can fix those clones at the same time. I don't know of a case where we've had to 'cvs up' the checkout on a slave, other than for a full version upgrade, so I don't think there's any point in spending time doing it just for this migration.

The new repositories will be here:
http://hg.mozilla.org/build/buildbot
http://hg.mozilla.org/build/buildbotcustom

When the CVS modules are deleted I will add READMEs into those directories which point to the new repositories.

Comment 6

[[e-mail] (:bhearsum)]

After doing some initial tests I think that we'd be better off to keep mozilla/tools/buildbot and start fresh and import the current tip of that to Mercurial. Two reasons for this:
1) The CVS history here is littered with vendor branches and other branches. We're not going to get a good, clean import here.
2) Talos still uses the BUILDBOT_0_7_5_BRANCH so we need to keep that intact.

I'll move forward with this tomorrow barring objections.

Comment 7

[[e-mail] (:bhearsum)]

Okay, I've got two test repositories set-up:
http://hg.mozilla.org/users/bhearsum_mozilla.com/buildbotcustom/
and
http://hg.mozilla.org/users/bhearsum_mozilla.com/buildbot/

The buildbotcustom one is an 'hg convert' imported repository as of a few minutes ago.

The buildbot one is the Buildbot 0.7.9 tarball plus a bunch some manually applied patches - most of which are in the master upstream repository. After that, there's minor differences in the trunk of buildbot in our CVS repository:
* Remove some unused imports (to match upstream)
* Remove TinderboxPoller (because it lives in buildbotcustom and the talos config directories)
* Shortened comment in process/base.py
* Whitespaces changes to match upstream

I've filed bug 475539 to get the new repositories created and I'll push the contents of these repositories to them once that happens.

Comment 8

[[e-mail] (:bhearsum)]

Alright, the new repositories have been populated. I've updated the checkouts on:
staging-master
staging-1.9-master
production-1.8-master
production-1.9-master
production-master
sm-try-master
sm-staging-try-master

I had to update Python (and subsequently reinstall zope/twisted) on production-1.8-master, because we apparently have some code that is Python 2.5 specific. No problems here though.

Leaving this bug open until I remove mozilla/tools/buildbotcustom on Friday.

Comment 9

[[e-mail] (:bhearsum)]

Alright, mozilla/tools/buildbotcustom/* has been deleted and replaced with a README pointing to the new home.

mozilla/tools/buildbot/README has been updated to note the new home for that code.

We're all done here.

Comment 10

[Serge Gautherie (:sgautherie)]

V.Fixed