470045 - Add -moz-appearance: -moz-mac-scopebar

Status: RESOLVED INVALID

(Core :: Widget: Cocoa, defect)

Description

[Markus Stange [:mstange]]

Attachment: render part, v1

(Also see URL.)

We're using scope bars in the Bookmarks Organizer and in the Error Console, and I'm planning to use them in bug 466642, too.

I think it's worth introducing a -moz-appearance for them.

This patch is on top of that in bug 449442.

Comment 1

[Josh Aas]

What is a scope bar, screenshot?

Comment 2

[Markus Stange [:mstange]]

It's a toolbar with a light gradient. Screenshots are here (see URL field):
http://developer.apple.com/DOCUMENTATION/UserExperience/Conceptual/AppleHIGuidelines/XHIGWindows/chapter_18_section_4.html#//apple_ref/doc/uid/20000961-SW3

Comment 3

[Robert O'Callahan (:roc) (email my personal email if necessary)]

The patch looks fine, but how do we decide when it's worth introducing a -moz-appearance value and implementing the rendering in native code?

Comment 4

[Markus Stange [:mstange]]

That's a good question...

I can think of three criteria but this patch satisfies neither of them:
 - Code simplification - not really, the CSS for scope bars is easy
 - Less total LOC - not the case; scope bars only need 3 lines of CSS at most,
   so we'd need a lot of them to make up for the lines that this patch adds
 - Sometimes -moz-appearance can do things that can't be done easily with CSS,
   like adapting to the OS theme - also not the case here.

Now I'm convinced that it's not worth it. :-)