470112 - Preference mail.toolbars.showbutton.junk doesn't work in Thunderbird - remove old prefs from about:config

Status: RESOLVED FIXED

(Thunderbird :: Preferences, defect)

Description

[Trever Adams]

User-Agent:       Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.0.4) Gecko/2008111217 Fedora/3.0.4-1.fc10 Firefox/3.0.4
Build Identifier: version 2.0.0.18 (20081119)

Setting mail.toolbars.showbutton.junk to false doesn't hide the button. This should hide the button and toolbar preferences should be stored in prefs.js. They do not seem to be.

Reproducible: Always

Steps to Reproduce:
1. Set user_pref("mail.toolbars.showbutton.junk", false); either in prefs.js or through the config dialog
2. Junk is still showing


Expected Results:  
Junk Button should be hidden.

Comment 1

[Mark Banner (:standard8)]

To remove the junk button from the toolbar, you should right click on the toolbar and select customise, you can then drag the button off of the toolbar onto the customise window.

I'd resolve this invalid, but we should really just remove those preferences from being displayed in about:config as they only apply to SeaMonkey, not Thunderbird.

Comment 2

[Mark Banner (:standard8)]

Attachment: The fix

TB doesn't need these prefs.

Comment 3

[Mark Banner (:standard8)]

Checked in: http://hg.mozilla.org/comm-central/rev/76d42f0ec79f

Comment 4

[Trever Adams]

This isn't fixed. There should be a way to progmatically remove it. Think business installations, etc.

Going to every machine and customizing the toolbar is NOT the solution.

Comment 5

[Mark Banner (:standard8)]

(In reply to comment #4)
> This isn't fixed. There should be a way to progmatically remove it. Think
> business installations, etc.
> 
> Going to every machine and customizing the toolbar is NOT the solution.

One option would be to write an extension to overlay the toolbar and force the button to be hidden by setting an appropriate xul attribute. This could be a minimal extension that you can install by default.

Comment 6

[Philip Chee]

I was going to remove those lines completely when I turn on toolbar customization in SeaMonkey MailNews (RSN) so I don't see the point of this #ifdef.

Comment 7

[Mark Banner (:standard8)]

(In reply to comment #6)
> I was going to remove those lines completely when I turn on toolbar
> customization in SeaMonkey MailNews (RSN) so I don't see the point of this
> #ifdef.

That did cross my mind, however I didn't know exactly when that would happen and these prefs haven't been applicable to TB for a long time.