Closed Bug 47016 Opened 24 years ago Closed 21 years ago

Leak gDefCharset in DocumentViewerImpl::GetDefaultCharacterSet()

Categories

(Core :: Layout, defect, P3)

Product:
Core
Component:
Layout
Platform:
x86
Windows 98
Type:
defect

Tracking

()

Status:
RESOLVED WORKSFORME
Milestone:
Future

People

(Reporter: rbs, Assigned: ftang)

Details

(Keywords: memory-leak) 

Filling this bug, for the record, so that it doesn't get forgotten later.

layout/base/src/nsDocumentWiewer.cpp has the following:

NS_IMETHODIMP DocumentViewerImpl::GetDefaultCharacterSet(PRUnichar** 
aDefaultCharacterSet)
{
  NS_ENSURE_ARG_POINTER(aDefaultCharacterSet);
  NS_ENSURE_STATE(mContainer);

  static PRUnichar *gDefCharset = nsnull;    // XXX: memory leak!

...
}
Keywords: mlk
Re-assigning bugs on Clayton's list opened between 7/29 and 8/4 to Kevin for
further triage.
Assignee: clayton → kmcclusk
Reassigning to ftang.
Assignee: kmcclusk → ftang
mark as assign
Status: NEW → ASSIGNED
Reassigning to Brian.
Assignee: ftang → bstell
Status: ASSIGNED → NEW
Status: NEW → ASSIGNED
Target Milestone: --- → mozilla0.9.1
Rather than trying an optimal solution that isn't necessary (given that a
charset is generally a short string), what about fixing this bug by just doing
gDefCharset[100] or some other length, and reworking the logic so that it
is defaulted to ISO-8859-1 if the length is short.
Target Milestone: mozilla0.9.1 → mozilla0.9.2
reassign to yokoyama and mark as future
Assignee: bstell → yokoyama
Status: ASSIGNED → NEW
Target Milestone: mozilla0.9.2 → Future
Accepting.
Status: NEW → ASSIGNED
Blocks: 92580
Setting milestone to not-too-distant-future.
Target Milestone: Future → mozilla0.9.6
No longer blocks: 92580
give it back to ftang
Assignee: yokoyama → ftang
Status: ASSIGNED → NEW
Target Milestone: mozilla0.9.6 → mozilla0.9.7
small leaking, set to future.
Target Milestone: mozilla0.9.7 → Future
Status: NEW → ASSIGNED
The code referenced in comment 0 no longer exists. (In particular, there is no
gDefCharset anymore.)
Status: ASSIGNED → RESOLVED
Closed: 21 years ago
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.