Closed Bug 470194 Opened 16 years ago Closed 15 years ago

Save/restore thread pane scroll position in tabs

Categories

(Thunderbird :: Mail Window Front End, enhancement)

enhancement
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 3.0b2

People

(Reporter: beckley, Assigned: beckley)

Details

Attachments

(1 file)

When switching between tabs it would be nice and consistent if the scroll position of the thread pane for a folder would get restored to where it was when the folder tab was moved away from it.

Steps to reproduce:
1. Select a folder that has at least a few more messages in it that can be displayed in the thread pane
2. Scroll all the way to the bottom of the thread pane
3. Select the next to last message
4. Open up another folder (or a message, doesn't matter) in to a new tab
5. Switch back to the first tab

Expected result:
Thread pane looks like it did after step #3 above: scrolled all the way to the last message and next to last message selected

Actual result:
Previously selected message is correctly selected, but that selected message is at the bottom of the thread pane view instead of the last message in the folder
Flags: wanted-thunderbird3?
Pretty easy fix.  It has one interesting twist in that it will always ensure that one of the selected items will be visible when the tab is re-focused (due to the asynchronous call to gDBView.selectFolderMsgByKey).  This means that the scroll position will not be identical in the case where the selected message was out of view when moved away from the tab.  I think this is OK because (1) It won't happen very often (how often do you scroll the selected message out of view?), and (2) it's probably better to have the selected message be visible when you return to the tab.

Adding Bryan as ui-review so that he can give UI feedback.
Attachment #353648 - Flags: ui-review?(clarkbw)
Attachment #353648 - Flags: review?(bugzilla)
Attachment #353648 - Flags: ui-review?(clarkbw) → ui-review+
Comment on attachment 353648 [details] [diff] [review]
[checked in] Simple implementation

The scroll change seems like a reasonable consequence of this improvement.  Looks good to me.
It does suck a lot that the whole tab view doesn't stay "as is" when switching tabs. Try reading long feed pages and switch between tabs...
(I'm sure this is an improvement, though.)
Flags: wanted-thunderbird3? → wanted-thunderbird3+
Comment on attachment 353648 [details] [diff] [review]
[checked in] Simple implementation


>+      
>+      document.getElementById("threadTree").treeBoxObject.scrollToRow(aTab.firstVisibleRow);

nit: unnecessary whitespace on blank line.

As its just one small change, I've fixed it and checked it in for you:

http://hg.mozilla.org/comm-central/rev/d8383c5f7cdb
Attachment #353648 - Attachment description: Simple implementation → [checked in] Simple implementation
Attachment #353648 - Flags: review?(bugzilla) → review+
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 3.0b2
You need to log in before you can comment on or make changes to this bug.