Update installer for Sunbird

RESOLVED FIXED in 1.0b1

Status

defect
RESOLVED FIXED
11 years ago
8 years ago

People

(Reporter: rstrong, Assigned: rstrong)

Tracking

Trunk
1.0b1
x86
Windows Vista

Details

Attachments

(4 attachments, 7 obsolete attachments)

825 bytes, patch
jimm
: review+
Details | Diff | Splinter Review
79.82 KB, patch
cmtalbert
: review+
Details | Diff | Splinter Review
103.39 KB, patch
rstrong
: review+
Details | Diff | Splinter Review
5.26 KB, patch
rstrong
: review+
Details | Diff | Splinter Review
The installer needs to be updated to take advantage of the changes used by all other applications and to allow using the Unicode version of NSIS.
Jim, this is a simple patch to remove an ifdef for MOZ_SUNBIRD from makensis.mk so I can get Sunbird's installer up to date in order to convert the installer to Unicode. Thanks
Attachment #353720 - Flags: review?(jmathies)
note: I'm going to first patch Sunbird's installer to make it up to date with the other installers and then submit a separate patch for updating it to Unicode NSIS.
This is the same as bug 469085 except it is for Sunbird. See bug 469085 for more info.

I'll also attach the binary
Attachment #353723 - Flags: review?(ssitter)

Updated

11 years ago
Attachment #353720 - Flags: review?(jmathies) → review+
Posted patch patch rev1 (obsolete) — Splinter Review
We are going to need this to convert our installers over to Unicode for Firefox 3.1. A second patch will be forthcoming to finish up the conversion to Unicode for Sunbird's installer.
Attachment #353737 - Attachment is obsolete: true
Attachment #353747 - Flags: review?(ssitter)
Comment on attachment 353723 [details] [diff] [review]
Patch for Sunbird's 7zSD.sfx - checked in

Also requesting review from Clint since he is a Sunbird installer peer and this will need to land soon.
Comment on attachment 353747 [details] [diff] [review]
patch rev1

Talked with Clint and he is going to do the reviews
Note: I've made a slight change in my repo to the un.preFinish function in uninstaller.nsi as follows to prevent the ability to open the survey for Vista since this process will be running elevated which would be a security issue.

!ifndef NO_UNINSTALL_SURVEY
Function un.preFinish
  ; Do not modify the finish page if there is a reboot pending.
  ${Unless} ${RebootFlag}
    ; Do not modify the finish page if the OS is Vista or above since the process
    ; will be running elevated.
    ${If} ${AtLeastWinVista}
      !insertmacro MUI_INSTALLOPTIONS_WRITE "ioSpecial.ini" "settings" "NumFields" "3"
    ${Else}
      ; When we add an optional action to the finish page the cancel button
      ; is enabled. This disables it and leaves the finish button as the
      ; only choice.
      !insertmacro MUI_INSTALLOPTIONS_WRITE "ioSpecial.ini" "settings" "cancelenabled" "0"
    ${EndIf}
  ${EndUnless}
FunctionEnd
!endif
This is for when we enable Unicode for the installer and needs the patch from bug 305039, attachment #353720 [details] [diff] [review], attachment #353723 [details] [diff] [review], and attachment #353747 [details] [diff] [review]

note: to apply this you don't need -p1 since I diff'd it locally
Attachment #353789 - Flags: review?(ctalbert)
Status: NEW → ASSIGNED

Comment 13

11 years ago
Comment on attachment 353747 [details] [diff] [review]
patch rev1

This looks good.  Thanks for the patch, Rob.  r=ctalbert
Attachment #353747 - Flags: review?(ctalbert) → review+

Updated

11 years ago
Attachment #353789 - Flags: review?(ctalbert) → review+

Comment 14

11 years ago
Comment on attachment 353789 [details] [diff] [review]
patch for Unicode support rev1

Rob, I have one comment here.  Could you add a comment in here so that future users can easily determine in which batch a new file should go?  

For example, if I'm a new sunbird installer guy, and I want to add my file to this makefile, how do I know if it should go in INSTALLER_FILES_CONV or INSTLALLER_FILES or what have you.  I realize the distinction between installer and branding files is pretty coherent, and I imagine the answer to this is: if your file has strings, it needs to be converted, but it'd be nice to have that documented for the future.

r=ctalbert with that nit
(In reply to comment #14)
> (From update of attachment 353789 [details] [diff] [review])
> Rob, I have one comment here.  Could you add a comment in here so that future
> users can easily determine in which batch a new file should go?  
Not a problem and will do

Updated

11 years ago
Attachment #353723 - Flags: review?(ctalbert) → review+

Comment 16

11 years ago
Comment on attachment 353723 [details] [diff] [review]
Patch for Sunbird's 7zSD.sfx - checked in

r=ctalbert
Forgot to include the new files in the diff
Attachment #353903 - Attachment is obsolete: true
Attachment #353904 - Flags: review+
Carrying forward r+

Changed the comment to
+# All script and locale files used by the Unicode version of NSIS need to be
+# converted from UTF-8 to UTF-16LE

This patch requires the patch from bug 305039 and won't be pushed to comm-central until the patch from bug 305039 is pushed to mozilla-1.9.1
Attachment #353789 - Attachment is obsolete: true
Attachment #354095 - Flags: review+
Attachment #353720 - Attachment description: patch for mozilla-central → patch for mozilla-central - checked in
Attachment #353723 - Attachment description: Patch for Sunbird's 7zSD.sfx → Patch for Sunbird's 7zSD.sfx - checked in
Pushed to comm-central
http://hg.mozilla.org/comm-central/rev/19e24a3d455e
Status: ASSIGNED → RESOLVED
Last Resolved: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → 1.0
Attachment #354095 - Attachment description: patch for Unicode support rev2 → patch for Unicode support rev2 (checked in)
Rob, how can I verify the fix? Just grabbing the Sunbird installer from this location?

ftp://ftp.mozilla.org/pub/calendar/sunbird/nightly/latest-comm-central-sunbird/
Summary: Update installer → Update installer for Sunbird
It would be damn near impossible to list everything the patches in this bug changed as individual line items since no one has updated the Sunbird installer in a very long time. The patches in this bug made the Sunbird installer have the same features as the Firefox installer except for the remove profiles on uninstall and take over defaults. Sunbird doesn't have Shell Integration code yet so there is also no set as default functionality.

The link you provided has the changes but you might want to verify the strings appear correctly in a Unicode version of a localized installer
http://ftp.mozilla.org/pub/mozilla.org/calendar/sunbird/nightly/latest-comm-central-sunbird-l10n/

The main new features are install when files are in use and Unicode support.
These bugs are likely targeted at Lightning 1.0b1, not Lightning 1.0. If this change was done in error, please adjust the target milestone to its correct value. To filter on this bugspam, you can use "lightning-10-target-move".
Target Milestone: 1.0 → 1.0b1
You need to log in before you can comment on or make changes to this bug.