470197 - Update installer for Sunbird

Status: RESOLVED FIXED

(Calendar :: Sunbird Only, defect)

Description

[Robert Strong (they/them - no direct email)]

The installer needs to be updated to take advantage of the changes used by all other applications and to allow using the Unicode version of NSIS.

Comment 1

[Robert Strong (they/them - no direct email)]

Attachment: patch in progress

Comment 2

[Robert Strong (they/them - no direct email)]

Attachment: patch in progress rev2

Comment 3

[Robert Strong (they/them - no direct email)]

Attachment: patch for mozilla-central - checked in

Jim, this is a simple patch to remove an ifdef for MOZ_SUNBIRD from makensis.mk so I can get Sunbird's installer up to date in order to convert the installer to Unicode. Thanks

Comment 4

[Robert Strong (they/them - no direct email)]

note: I'm going to first patch Sunbird's installer to make it up to date with the other installers and then submit a separate patch for updating it to Unicode NSIS.

Comment 5

[Robert Strong (they/them - no direct email)]

Attachment: Patch for Sunbird's 7zSD.sfx - checked in

This is the same as bug 469085 except it is for Sunbird. See bug 469085 for more info.

I'll also attach the binary

Comment 6

[Robert Strong (they/them - no direct email)]

Attachment: 7zSD.sfx binary

Comment 7

[Robert Strong (they/them - no direct email)]

Attachment: patch in progress rev3 (almost there)

Comment 8

[Robert Strong (they/them - no direct email)]

Attachment: patch rev1

We are going to need this to convert our installers over to Unicode for Firefox 3.1. A second patch will be forthcoming to finish up the conversion to Unicode for Sunbird's installer.

Comment 9

[Robert Strong (they/them - no direct email)]

Comment on attachment 353723 [details] [diff] [review]
Patch for Sunbird's 7zSD.sfx - checked in

Also requesting review from Clint since he is a Sunbird installer peer and this will need to land soon.

Comment 10

[Robert Strong (they/them - no direct email)]

Comment on attachment 353747 [details] [diff] [review]
patch rev1

Talked with Clint and he is going to do the reviews

Comment 11

[Robert Strong (they/them - no direct email)]

Note: I've made a slight change in my repo to the un.preFinish function in uninstaller.nsi as follows to prevent the ability to open the survey for Vista since this process will be running elevated which would be a security issue.

!ifndef NO_UNINSTALL_SURVEY
Function un.preFinish
  ; Do not modify the finish page if there is a reboot pending.
  ${Unless} ${RebootFlag}
    ; Do not modify the finish page if the OS is Vista or above since the process
    ; will be running elevated.
    ${If} ${AtLeastWinVista}
      !insertmacro MUI_INSTALLOPTIONS_WRITE "ioSpecial.ini" "settings" "NumFields" "3"
    ${Else}
      ; When we add an optional action to the finish page the cancel button
      ; is enabled. This disables it and leaves the finish button as the
      ; only choice.
      !insertmacro MUI_INSTALLOPTIONS_WRITE "ioSpecial.ini" "settings" "cancelenabled" "0"
    ${EndIf}
  ${EndUnless}
FunctionEnd
!endif

Comment 12

[Robert Strong (they/them - no direct email)]

Attachment: patch for Unicode support rev1

This is for when we enable Unicode for the installer and needs the patch from bug 305039, attachment #353720 [details] [diff] [review], attachment #353723 [details] [diff] [review], and attachment #353747 [details] [diff] [review]

note: to apply this you don't need -p1 since I diff'd it locally

Comment 13

[cmtalbert]

Comment on attachment 353747 [details] [diff] [review]
patch rev1

This looks good.  Thanks for the patch, Rob.  r=ctalbert

Comment 14

[cmtalbert]

Comment on attachment 353789 [details] [diff] [review]
patch for Unicode support rev1

Rob, I have one comment here.  Could you add a comment in here so that future users can easily determine in which batch a new file should go?  

For example, if I'm a new sunbird installer guy, and I want to add my file to this makefile, how do I know if it should go in INSTALLER_FILES_CONV or INSTLALLER_FILES or what have you.  I realize the distinction between installer and branding files is pretty coherent, and I imagine the answer to this is: if your file has strings, it needs to be converted, but it'd be nice to have that documented for the future.

r=ctalbert with that nit

Comment 15

[Robert Strong (they/them - no direct email)]

(In reply to comment #14)
> (From update of attachment 353789 [details] [diff] [review])
> Rob, I have one comment here.  Could you add a comment in here so that future
> users can easily determine in which batch a new file should go?  
Not a problem and will do

Comment 16

[cmtalbert]

Comment on attachment 353723 [details] [diff] [review]
Patch for Sunbird's 7zSD.sfx - checked in

r=ctalbert

Comment 17

[Robert Strong (they/them - no direct email)]

Attachment: update installer patch as checked in

Comment 18

[Robert Strong (they/them - no direct email)]

Attachment: update installer patch as checked in

Forgot to include the new files in the diff

Comment 19

[Robert Strong (they/them - no direct email)]

Pushed to mozilla-1.9.1
http://hg.mozilla.org/releases/mozilla-1.9.1/rev/31ab984f9570

Pushed to mozilla-central
http://hg.mozilla.org/mozilla-central/rev/7d625a6b8a44beed8f6ffbbe3ab39ad9c284d15a

pushed to comm-central
http://hg.mozilla.org/comm-central/rev/6611a5482754

leaving open to land the patch for Unicode support after bug 305039 lands

Comment 20

[Robert Strong (they/them - no direct email)]

Attachment: patch for Unicode support rev2 (checked in)

Carrying forward r+

Changed the comment to
+# All script and locale files used by the Unicode version of NSIS need to be
+# converted from UTF-8 to UTF-16LE

This patch requires the patch from bug 305039 and won't be pushed to comm-central until the patch from bug 305039 is pushed to mozilla-1.9.1

Comment 21

[Robert Strong (they/them - no direct email)]

Pushed to comm-central
http://hg.mozilla.org/comm-central/rev/19e24a3d455e

Comment 22

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Rob, how can I verify the fix? Just grabbing the Sunbird installer from this location?

ftp://ftp.mozilla.org/pub/calendar/sunbird/nightly/latest-comm-central-sunbird/

Comment 23

[Robert Strong (they/them - no direct email)]

It would be damn near impossible to list everything the patches in this bug changed as individual line items since no one has updated the Sunbird installer in a very long time. The patches in this bug made the Sunbird installer have the same features as the Firefox installer except for the remove profiles on uninstall and take over defaults. Sunbird doesn't have Shell Integration code yet so there is also no set as default functionality.

The link you provided has the changes but you might want to verify the strings appear correctly in a Unicode version of a localized installer
http://ftp.mozilla.org/pub/mozilla.org/calendar/sunbird/nightly/latest-comm-central-sunbird-l10n/

The main new features are install when files are in use and Unicode support.

Comment 24

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

These bugs are likely targeted at Lightning 1.0b1, not Lightning 1.0. If this change was done in error, please adjust the target milestone to its correct value. To filter on this bugspam, you can use "lightning-10-target-move".