470231 - Auto-collapse bookmark manager folders expanded during bookmark dragging

Status: RESOLVED FIXED

(Camino Graveyard :: Bookmarks, enhancement)

Description

[Samuel Sidler (old account; do not CC)]

From feedback (doesn't seem like a bad idea):

When doing some bookmark re-arranging just now, I noticed a behavior that was irritating; whenever you drop a bookmark into a folder whose contents are not expanded, it automatically expands the folder to show its contents - taking up much of the screen real-estate and leading to me having to close it each time.  I suggest you just let the bookmark drop into the folder silently, much the way the finder works.

Comment 1

[Stuart Morgan]

This has come up before; I'm not sure whether we can control that behavior of outlines views.

Comment 2

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

I'm pretty sure this is standard NSOutlineView behavior (at least, that's what I think I remember smfr saying when I complained about it years ago), and it happens that it's much more sensitive to "hover" than the Carbon equivalent.

Comment 3

[Chris Lawson (gone)]

FWIW, this has been driving me crazy of late (doing a big bookmarks cleanup/organisation). Since we're already subclassing the outline view, I wonder if there's any way, even via a private API, we might be able to

a) make it slightly less sensitive to hovering; and
b) tie the expand behaviour to the spring-loaded folder delay time so it doesn't happen unless the hover lasts for X seconds.

I'm not all that familiar with the various Finder replacements out there, but I know there are several. Maybe it's worth asking a couple of their authors how they handled problems like this? (I assume other people have probably run into this sort of thing before, and at least some of them have probably worked around it.)

Comment 4

[Christopher Henderson]

Attachment: Spring-loaded folders

There is probably a way to not expand folders on drags (http://lists.apple.com/archives/Cocoa-dev/2004//Sep/msg00327.html seems like a good place to start). 

Alternatively, here is a patch that automatically collapses folders that were expanded during a drag. NetNewsWire does this in its subscriptions list, and I find it to be very useful. It allows me to place the item exactly where I want, and leaves the list nice and collapsed when I'm finished.

Comment 5

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

If we do anything, I think I'd prefer hendy's patch; he's also been talking about investigating whether we still need to subclass the outline view anymore, which would in turn mean less work for us each new OS release re-implementing standard behaviors.

Comment 6

[Chris Lawson (gone)]

Yeah, that will solve most of my objections to the default behaviour. I always thought it was weird that they stayed open anyway.

I'd personally still like to see the expansion not happen *immediately*, but automatically collapsing them after the drag is done will help matters a lot.

Comment 7

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

See bug 180432 and bug 278827 ;)

Comment 8

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

I'm going to go ahead and confirm this for auto-close, since we have three in favor.

Comment 9

[Christopher Henderson]

Attachment: Updated patch

Updated patch, as Bug 360858 changed line numbers. The code is simple enough that I'll kick it straight to sr.

Comment 10

[Stuart Morgan]

Comment on attachment 358279 [details] [diff] [review]
Updated patch

sr=smorgan

Comment 11

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Landed on cvs trunk.

The delay before closing was quite a bit longer than I expected, though; I was most of the way to closing them myself.

Comment 12

[philippe (part-time)]

(In reply to comment #11)
 
> The delay before closing was quite a bit longer than I expected, though; I was
> most of the way to closing them myself.

It is about the same speed as what NNW does, on my set up.

Thanks for fixing this !