Closed Bug 470263 Opened 16 years ago Closed 15 years ago

Use of <tree> needs to be updated to keep current selection in view upon reflow.

Categories

(Thunderbird :: Mail Window Front End, defect)

defect
Not set
trivial

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: steve, Assigned: steve)

References

Details

Attachments

(1 file, 1 obsolete file)

User-Agent:       Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.0.5) Gecko/2008120121 Firefox/3.0.5
Build Identifier: 

Per bug 454632, the default <tree> behaviour of always scrolling to keep the current selection viewable, while desirable in Thunderbird, isn't generally desirable in other uses of <tree>.

The patch in 454632 will update <tree> to default to not keeping the current selection viewable upon reflow, which means Thunderbird will need to be updated to set the 'keepcurrentinview' attribute true.

Reproducible: Always

Steps to Reproduce:
1. Select an item in the tree.
2. Resize the containing element
3. Weep a little.
Depends on: 454632
Blocks: songbird
Component: General → Mail Window Front End
Version: unspecified → Trunk
QA Contact: general → front-end
Attached patch Patch v1 (obsolete) — Splinter Review
Adds the 'keepcurrentinview' attribute to the thread pane <tree> element.
Assignee: nobody → steve
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Attachment #353852 - Flags: review?
Comment on attachment 353852 [details] [diff] [review]
Patch v1

this looks ok to me - checking with Neil for SM part.
Attachment #353852 - Flags: superreview?(neil)
Attachment #353852 - Flags: review?
Attachment #353852 - Flags: review+
Attachment #353852 - Flags: review?(mnyromyr)
Comment on attachment 353852 [details] [diff] [review]
Patch v1

I'd add the attribute in the middle like you did for Thunderbird, this avoids fiddling around with /> ;-)
I think Mnyromyr should get to look at this too.
Ah, I added it to the end in order to keep the true/false attributes grouped together - but I'm fine with either.. 'tis a trivial change either way :)
Comment on attachment 353852 [details] [diff] [review]
Patch v1

You need to patch up the folderTree as well; and please follow Neil's advice on attribute placement.

r=me with that fixed
Attachment #353852 - Flags: review?(mnyromyr) → review+
Attached patch Patch v2Splinter Review
Addresses Mnyromyr's comments (to update folderTree as well)
Addresses Neil's comments re: placement of attributes
Attachment #353852 - Attachment is obsolete: true
Attachment #356249 - Flags: superreview?(neil)
Attachment #353852 - Flags: superreview?(neil)
Moving 454632 from Depends to Blocks since 454632 can't land until this patch lands
Blocks: 454632
No longer depends on: 454632
Comment on attachment 356249 [details] [diff] [review]
Patch v2

You weren't around when I finally managed to persuade Mnyromyr that we don't need it for the folder pane after all :-)
Attachment #356249 - Flags: superreview?(neil) → superreview+
Pushed:

changeset:   1628:6bb13202f7cd
user:        Nick Kreeger <nick.kreeger@park.edu>
date:        Tue Jan 13 10:40:17 2009 -0800
summary:     Fixing Bug 470263 - Use of <tree> needs to be updated to keep current selection in view upon reflow. r=bienvenu, mnyromyr. sr=neil. Patch by Stephen Lau <steve@grommit.com>.

changeset:   1630:47c9fe5de473
tag:         tip
parent:      1628:6bb13202f7cd
parent:      1629:4cfbdb787aa3
user:        Nick Kreeger <nick.kreeger@park.edu>
date:        Tue Jan 13 10:44:45 2009 -0800
summary:     Merge bug 470263
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.