470268 - Collections Extension: Avoid horizontal scrolling at default size

Status: RESOLVED FIXED

(addons.mozilla.org Graveyard :: Collector Extension, defect)

Description

[Brian King [:kinger]]

Check default size of Feeds panel on clean install/profile to make sure no horizontal scrolling is happening (all platforms).

Comment 1

[Brian King [:kinger]]

Attachment: Mac Default 1280x800 resolution

Comment 2

[Brian King [:kinger]]

Attachment: Vista Default 1920x1200 resolution

So it seems like the resolution has no part in this equation, just the window size vs. the data that needs to be put in. The biggest culprit if the left sidebar which is a first for any panel in the Add-ons window.

Comment 3

[Brian King [:kinger]]

Recent changes seemed to have caused a related regression. When the window is made small enough, both the whole panel, and the list panel inside, have horizontal scrolling.

Comment 4

[Brian King [:kinger]]

One solution would be to make the Add-ons window bigger by default.

Dave, any chances?

Comment 5

[Dave Townsend [:mossop]]

(In reply to comment #4)
> One solution would be to make the Add-ons window bigger by default.
> 
> Dave, any chances?

If anything the discussions in bug 431023 were talking about making it a bit narrower I think. I'm really not bothered all that much with what the default size is and if you can get UX to sign off on a change then I'm happy to take it, but you have 2 days to get ui-review, and landed on trunk then on branch. After that we are string frozen so that is the deadline for taking any change to the size for 3.5.

Comment 6

[Brian King [:kinger]]

(In reply to comment #5)
> If anything the discussions in bug 431023 were talking about making it a bit
> narrower I think. I'm really not bothered all that much with what the default
> size is and if you can get UX to sign off on a change then I'm happy to take
> it, but you have 2 days to get ui-review, and landed on trunk then on branch.
> After that we are string frozen so that is the deadline for taking any change
> to the size for 3.5.

Thanks, but I don't think it's worth all that bother. We'll try for another solution.

Comment 7

[Brian King [:kinger]]

Another idea: the first time the Add-ons window opens after the extension is installed, force resize the window to an acceptable size.

Dave or Justin, any other ideas?

Comment 8

[Justin Scott [:fligtar]]

That sounds fine to me... I'm not sure of the technical difficulties involved, but as long as the add-ons manager is large enough when the subscriptions pane is present, I'm happy.

Comment 9

[Brian King [:kinger]]

Fixed in revision 24329. This is a 1-time deal only, the first time the Add-ons window is opened after the extension install. Width only is changed to 700, which seemed like a sane size after playing around with various sizes.