470510 - Investigate not clearing the inner window's scope on page transition (JS_ClearScope)

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Blake Kaplan (:mrbkap) (inactive)]

Attachment: Patch

We've wanted to do this for a while (ever since the inner/outer window split) but have been afraid to do so because of leak possibilities. It turns out that we do leak, but we should be able to fix it.

I'm attaching a patch that implements the core of this idea as well as changes to the makefile in content/base/test/ that, if you run with --test-path=content/base/test shows a leak of 5 nsGlobalWindows (I'll attach the full dump in a second).

Comment 1

[Blake Kaplan (:mrbkap) (inactive)]

Attachment: Leak dump

Comment 2

[Boris Zbarsky [:bzbarsky]]

Note that an additional worry is not just shutown leaks but window-lifetime or app-lifetime leaks...

Comment 3

[Blake Kaplan (:mrbkap) (inactive)]

Attachment: updated

This doesn't leak when run against the tests in content/base, but does on the try server.

Comment 4

[Benoit Jacob [:bjacob] (mostly away)]

Ping... I have a user who's getting "attempted to run compile-and-go script on a cleared scope" and MXR points to this bug after a few hoops.

[10:38] <__doc__> bjacob: btw. do you have any idea what the error "attempted to run compile-and-go script on a cleared scope" means?
[10:39] <__doc__> bjacob: I only get it when I replace setTimeout with mozRequestAnimationFrame

Looks like a patch here has been waiting for a review since 2009?

Comment 5

[Benoit Jacob [:bjacob] (mostly away)]

[10:44] <__doc__> but it only appears if the mozRequestAnimationFrame is inside a conditional :)

Comment 6

[Boris Zbarsky [:bzbarsky]]

Benoit, what build is that user using?

Comment 7

[Benoit Jacob [:bjacob] (mostly away)]

He says Firefox 4.0.1 on Ubuntu 10.10.

Comment 8

[Boris Zbarsky [:bzbarsky]]

Then he's seeing bug 607529; fixed in fx5.

Comment 9

[Benoit Jacob [:bjacob] (mostly away)]

Excellent, thanks.

Comment 10

[Peter Van der Beken [:peterv]]

Comment on attachment 409699 [details] [diff] [review]
updated

This patch hasn't been waiting for review but for me to debug the leaks. I've been doing that (see also bug 637099), but it's taking a long time.

Comment 11

[Alan Smith]

I'm getting "attempt to run compile-and-go script on a cleared scope" in 7.0.1 on XP SP3 running GEPlugin.
Happy to provide more info, but not sure how much detail is appropriate.
error is reported from default.I.js: 41 - deep inside GEPlugin I think.
I'm a js developer trying to get my app running in FF - it runs fine in Chrome!

Comment 12

[Johnny Stenback (:jst)]

This is now fixed by peterv's work in bug 637099.