Closed
Bug 470703
Opened 16 years ago
Closed 16 years ago
-moz-box-ordinal-group should not allow negative values
Categories
(Core :: CSS Parsing and Computation, defect)
Core
CSS Parsing and Computation
Tracking
()
RESOLVED
FIXED
mozilla1.9.2a1
People
(Reporter: dbaron, Assigned: dbaron)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
|
1.94 KB,
patch
|
enndeakin
:
review+
bzbarsky
:
superreview+
|
Details | Diff | Splinter Review |
-moz-box-ordinal-group currently stores its value as an unsigned integer and handles it as such. However, we accept negative integers when parsing the property, which I think we should not do. (Doing so causes us to fail a bunch of serialization tests because we reserialize -1 as something in scientific notation.) This changes the parsing code to reject negative values.
Attachment #354087 -
Flags: superreview?(bzbarsky)
Attachment #354087 -
Flags: review?(enndeakin)
|
||
Updated•16 years ago
|
Attachment #354087 -
Flags: review?(enndeakin) → review+
|
||
Updated•16 years ago
|
Attachment #354087 -
Flags: superreview?(bzbarsky) → superreview+
|
Assignee | |
Comment 1•16 years ago
|
||
Fixed: http://hg.mozilla.org/mozilla-central/rev/689a6d906a64
Blocks: 377731
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.2a1
|
||
Updated•16 years ago
|
Flags: in-testsuite+
You need to log in
before you can comment on or make changes to this bug.
Description
•