Closed
Bug 470706
Opened 16 years ago
Closed 16 years ago
should reject 'stroke-miterlimit' values less than 1
Categories
(Core :: CSS Parsing and Computation, defect)
Core
CSS Parsing and Computation
Tracking
()
RESOLVED
FIXED
mozilla1.9.2a1
People
(Reporter: dbaron, Assigned: dbaron)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
|
2.97 KB,
patch
|
jwatt
:
review+
bzbarsky
:
superreview+
|
Details | Diff | Splinter Review |
While the SVG 1.1 spec says that any document with incorrect values for the 'stroke-miterlimit' CSS property should be "in error" (ugh), we just instead assume that it meant to use the standard CSS error handling rules for property syntax errors. However, we're currently treating any value less than 0 as an error, while the spec says that any value less than 1 should be an error. This fixes the CSS parser to do that, and thus fixes the test failure.
Attachment #354091 -
Flags: superreview?(bzbarsky)
Attachment #354091 -
Flags: review?(jwatt)
|
||
Comment 1•16 years ago
|
||
Comment on attachment 354091 [details] [diff] [review] patch r=jwatt
Attachment #354091 -
Flags: review?(jwatt) → review+
|
|
||
Updated•16 years ago
|
Attachment #354091 -
Flags: superreview?(bzbarsky) → superreview+
|
Assignee | |
Comment 2•16 years ago
|
||
Fixed: http://hg.mozilla.org/mozilla-central/rev/d24fad239a51
Blocks: 377731
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.2a1
|
||
Updated•16 years ago
|
Flags: in-testsuite+
You need to log in
before you can comment on or make changes to this bug.
Description
•