470841 - source files not linked to hgweb in frames tab

Status: RESOLVED WORKSFORME

(Socorro :: General, task)

Description

[(not currently active) Ted Mielczarek]

If you look at the Frames tab of a crash report, the source column is supposed to have links to hgweb to the source file specified there. If you look at the raw dump you can see that we have all the info needed to make these links:
0|0|js3250.dll|nanojit::LirBufWriter::insLink(nanojit::LOpcode,nanojit::LIns *)|hg:hg.mozilla.org//mozilla-central:js/src/nanojit/LIR.cpp:0bf8379c0bd0|423|0x18

Did this regress at some point?

Comment 1

[timeless]

while you're at it, could you switch to mxr ?rev= instead? :)

Comment 2

[(not currently active) Ted Mielczarek]

No.

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Is there any ETA yet, when we will have this feature in Socorro? It was really helpful with Talkback.

Comment 5

[(not currently active) Ted Mielczarek]

This seems to WFM:
http://crash-stats.mozilla.com/report/index/9bf0964a-8795-4391-9de2-045852090811

Might have been a different issue.

Comment 6

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Ted, so this does only work with new incidents? The one given in the URL field is still not linkified.