Occasional few-pixel reftest failure in reftests/svg/smil/container/ (when moving elements between SVG document fragments)

NEW
Unassigned

Status

()

P5
normal
10 years ago
5 years ago

People

(Reporter: dholbert, Unassigned)

Tracking

({intermittent-failure})

Trunk
intermittent-failure
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [tests marked as random], URL)

Attachments

(14 attachments, 1 obsolete attachment)

7.82 KB, image/png
Details
7.82 KB, image/png
Details
12.98 KB, image/png
Details
7.66 KB, image/png
Details
7.66 KB, image/png
Details
11.34 KB, image/png
Details
6.83 KB, image/png
Details
6.83 KB, image/png
Details
10.86 KB, image/png
Details
1.11 KB, application/xhtml+xml
Details
740 bytes, application/xhtml+xml
Details
20.41 KB, text/plain
Details
62.15 KB, text/plain
Details
13.87 KB, patch
dholbert
: review+
Details | Diff | Splinter Review
(Reporter)

Description

10 years ago
When running the reftests added in bug 216462's latest patch, I ran into an occasional few-pixel reftest failure, which doesn't seem to be SMIL-specific. (I managed to reproduce it even after taking out all <animate> elements and all SMIL API calls)

It seems to be a random failure with low probability, though I often can reproduce it multiple times in a row and then can never reproduce it at all.  It seems to depend on environmental conditions.

I'll attach some reftest-snapshots of the failure, to demonstrate the problem.

I'm not sure how to resolve or debug this issue, since it's so hard to reproduce -- I'm mostly filing this bug to have a place to discuss & track it.
(Reporter)

Comment 1

10 years ago
Created attachment 354251 [details]
snapshot 1a: enveloped-tree-1 testcase
(Reporter)

Comment 2

10 years ago
Created attachment 354252 [details]
snapshot 1b: enveloped-tree-1 reference
(Reporter)

Comment 3

10 years ago
Created attachment 354253 [details]
snapshot 1c: enveloped-tree-1 DIFFS
(Reporter)

Comment 4

10 years ago
Created attachment 354254 [details]
snapshot 2a: moved-tree-1 testcase
(Reporter)

Updated

10 years ago
Attachment #354252 - Attachment description: snapshot 1b: enveloped-tree-1 reference case → snapshot 1b: enveloped-tree-1 reference
(Reporter)

Comment 5

10 years ago
Created attachment 354255 [details]
snapshot 2b: moved-tree-1 reference
(Reporter)

Comment 6

10 years ago
Created attachment 354256 [details]
snapshot 2c: moved-tree-1 DIFFS
(Reporter)

Comment 7

10 years ago
Created attachment 354257 [details]
snapshot 3a: enveloped-tree no-animation testcase
(Reporter)

Updated

10 years ago
Attachment #354257 - Attachment description: snapshot 3a: enveloped-tree no animation testcase → snapshot 3a: enveloped-tree no-animation testcase
(Reporter)

Comment 8

10 years ago
Created attachment 354258 [details]
snapshot 3b: enveloped-tree no-animation reference
(Reporter)

Comment 9

10 years ago
Created attachment 354259 [details]
snapshot 3c: enveloped-tree no-animation DIFFS
(Reporter)

Comment 10

10 years ago
Created attachment 354260 [details]
testcase 1 (enveloped-tree no-animation)

Here's the reftest testcase behind "snapshot 3a: enveloped-tree no-animation testcase" (attachment 354257 [details]).  It's just a modified version of "enveloped-tree-1", with one circle removed for simplicity and with all animations & SMIL API calls removed.
(Reporter)

Comment 11

10 years ago
Created attachment 354261 [details]
reference 1 (enveloped-tree no-animation)

Here's the reftest reference case behind "snapshot 3b: enveloped-tree no-animation
reference" (attachment 354258 [details]).
(Reporter)

Updated

10 years ago
Depends on: 216462
(Reporter)

Comment 12

9 years ago
Created attachment 404532 [details]
failure log for "moved-tree-1.xhtml" on mac

I've hit this bug with "moved-tree-1.xhtml" on the mac TryServer tinderboxen twice over the last week. e.g.
http://tinderbox.mozilla.org/showlog.cgi?log=MozillaTry/1254686026.1254695109.22469.gz

I'm attaching the failure log -- this can be pasted / loaded into Mozilla's "reftest-analyzer.xhtml" tool to see the few-pixel differences (available at http://hg.mozilla.org/mozilla-central/raw-file/tip/layout/tools/reftest/reftest-analyzer.xhtml )

Note that the differences in this failure are a few pixels at the left edge of the snapshot, whereas the differences shown in attachment "snapshot 2c" (using the same reftest) are at the right edge.  That may be a platform difference -- this new failure is from a mac tinderbox, whereas the old one was from my own Linux box.
(Reporter)

Comment 13

9 years ago
I've marked "moved-tree-1.xhtml" as being currently random, due to this bug:
http://hg.mozilla.org/mozilla-central/rev/f511a5abb19d
(Reporter)

Updated

9 years ago
Duplicate of this bug: 524098
deferred-anim-1.xhtml (from the duped bug 524098) was failing pretty frequently on mac.
(Reporter)

Comment 16

9 years ago
Yeah, that's not out of the ordinary for this bug.  (per comment 0, sometimes this can happen multiple times in a row / frequently, whereas other times I can't get it to happen at all)
(Reporter)

Updated

9 years ago
Summary: Occasional few-pixel reftest failure in SMIL reftests when moving elements between SVG documents → Occasional few-pixel reftest failure in reftests/svg/smil/container/ (when moving elements between SVG documents)
(Reporter)

Updated

9 years ago
Blocks: 438871
Depends on: 482402
Whiteboard: [orange][tests marked as random]
(Reporter)

Updated

9 years ago
OS: Linux → All
Hardware: x86 → All
(Reporter)

Updated

9 years ago
Summary: Occasional few-pixel reftest failure in reftests/svg/smil/container/ (when moving elements between SVG documents) → Occasional few-pixel reftest failure in reftests/svg/smil/container/ (when moving elements between SVG document fragments)
(Reporter)

Comment 17

8 years ago
Created attachment 474930 [details]
reftst output from Cedar OpenGL failures (deferred-tree-1.xhtml, deferred-tree-2a.xhtml, deferred-tree-2b.xhtml)

The Birch project branch (which is currently tracking some OpenGL-backend work) is hitting this failure (12-16px difference) frequently on a few more tests:
deferred-tree-1.xhtml, deferred-tree-2a.xhtml, deferred-tree-2b.xhtml
http://tinderbox.mozilla.org/showlog.cgi?log=Birch/1284407086.1284408730.26415.gz

reftest output from that log is attached.

It may turn out that the OpenGL backend makes this bug easier to reproduce -- if so, that'll greatly assist in debugging it! :) In the meantime, though, we might as well mark those three tests as random (or random-on-mac), as we have with other tests here.
I marked some of these reftests as random on OpenGL in http://hg.mozilla.org/mozilla-central/rev/eaba42694849
Daniel the WIP patch fixes everything except moved-tree. It looks like something has completely broken this since it was written as with or without this patch the test and the reference look completely different. Any ideas?
Created attachment 535951 [details] [diff] [review]
patch
Attachment #532522 - Attachment is obsolete: true
Attachment #535951 - Flags: review?(dholbert)
(Reporter)

Comment 22

7 years ago
Comment on attachment 535951 [details] [diff] [review]
patch

>-random == moved-tree-1.xhtml moved-tree-1-ref.xhtml  # bug 470868
[...]
>+== moved-tree-1.xhtml moved-tree-1-ref.xhtml

At least on my system, moved-tree still fails completely after this patch, as you mentioned in comment 20 here.  (The circle is at opposite ends of the green bar in testcase vs. reference.)

We probably need to replace "random" with "fails" for that one, rather than just removing 'random', right?  Could you do that & file a followup on that regression, to figure out what's going on there?

r=dholbert with that.  Thanks for fixing these!
Attachment #535951 - Flags: review?(dholbert) → review+
(Reporter)

Comment 23

7 years ago
(and note the followup bug number in reftest.list, so that the the 'fails' annotation will point to something)
(Assignee)

Updated

6 years ago
Keywords: intermittent-failure
(Assignee)

Updated

6 years ago
Whiteboard: [orange][tests marked as random] → [tests marked as random]

Updated

5 years ago
Priority: -- → P5
Robert, is this patch still good for fixing up (per comment 22) and landing?
Flags: needinfo?(longsonr)
As far as I know it is. I can't remember why I abandoned work on it now.
Flags: needinfo?(longsonr)
You need to log in before you can comment on or make changes to this bug.