471097 - Windows mozilla-central burning - "nsinstall: cannot copy js3250.lib"

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Justin Dolske [:Dolske]]

WINNT 5.2 mozilla-central build is burning, I think it's a stuck process on the box.

http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1230175606.1230176938.8666.gz

nsinstall: cannot copy js3250.lib to e:\builds\moz2_slave\mozilla-central-win32\build\obj-firefox\dist\lib\js3250.lib: The process cannot access the file because it is being used by another process.

(Ignore the "NMAKE : fatal error U1052: file 'makefile.sub' not found", that's just noise -- bug 468447).

Comment 1

[Frank Wein [:mcsmurf]]

Just a note, maybe this has to do with http://hg.mozilla.org/mozilla-central/rev/55e23c647137 and/or http://hg.mozilla.org/mozilla-central/rev/73be1c836d7f as the errors started around those two check-ins.

Comment 2

[Nick Thomas [:nthomas] (UTC+12)]

Build   Build start time     Build slave
result

red     2008/12/25 12:37:01  moz2-win32-slave17
red     2008/12/25 12:32:59  moz2-win32-slave15
red     2008/12/25 10:37:01  moz2-win32-slave12
green   2008/12/25 08:37:01  moz2-win32-slave05
red     2008/12/25 06:37:01  moz2-win32-slave02
red     2008/12/25 04:37:01  moz2-win32-slave16
green   2008/12/25 03:35:31  moz2-win32-slave11
red     2008/12/25 02:00:00  moz2-win32-slave13   NIGHTLY
...
red     2008/12/24 12:37:12  moz2-win32-slave13   First error

The first occurrence at 2008/12/24 12:37:12 confirms it's likely to be one of the those changes to the js build system, probably bug 467862 so I'll set blocking on that.

I can't find any processes hanging around on slave17, 15, or 13, but it's possible buildbot cleaned them up when the build failed. 

The smoking gun is that the nightly also burned with the same error, on a clobber build, this looks to me to be a problem building JS with make -j4 on windows [1]. Perhaps because the file locking is done differently on that platform.

[1] http://hg.mozilla.org/build/buildbot-configs/file/tip/mozilla2/win32/mozilla-central/nightly/mozconfig

Comment 3

[Phil Ringnalda (:philor)]

Backed out bug 467862 just to see what happens, because I'm curious like that.

Comment 4

[Phil Ringnalda (:philor)]

Err, and bug 462004 since it depended on bug 467862, which a smart person would have realized *before* burning anything that wasn't already burning.

Comment 5

[(not currently active) Ted Mielczarek]

Phil: thanks for backing that out while I was busy Christmasing. I suspect some weird interaction between my patches and bug 467583.

Comment 6

[(not currently active) Ted Mielczarek]

So I think the underlying problem here is that we're doing a PGO build on Win32, and we call "make install" in js/src to copy the libs and such into dist/bin. Unfortunately, the PGO build process on windows has a rule to force re-linking of libraries and executables, which gets tripped when we run the install target, so we wind up relinking js3250.dll and breaking things.

Comment 7

[(not currently active) Ted Mielczarek]

Filed bug 471188 on fixing that problem.

Comment 8

[Justin Dolske [:Dolske]]

Boxes seem green again, so I think this is fixed.