467862 - Build system should support building both a static and a shared library from the same Makefile

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Jim Blandy :jimb]

Some interesting questions arise: does this mean compiling two .o files for each source file, one PIC and one not?  GLIBC does this, using .o for static and .os for PIC, or something like that.

Comment 1

[Benjamin Smedberg]

I think not: I think we should compile both the shared and static library with PIC, using the same object files.

Comment 2

[(not currently active) Ted Mielczarek]

Attachment: allow both FORCE_STATIC_LIB and FORCE_SHARED_LIB in the same makefile

This allows you to set both FORCE_STATIC_LIB and FORCE_SHARED_LIB in the same Makefile. It also adds optional STATIC_LIBRARY_NAME and SHARED_LIBRARY_NAME variables, to rename one or the other. (They'll both default to LIBRARY_NAME.)

I don't think this patch 100% complete, because there were a few instances of $(LIBRARY_NAME) in rules.mk that I wasn't quite sure what to do with, notably:
The build-list.pl stuff, I have no idea what that does:
http://mxr.mozilla.org/mozilla-central/source/config/rules.mk#730
and this OS/2 block:
http://mxr.mozilla.org/mozilla-central/source/config/rules.mk#1076

Comment 3

[Benjamin Smedberg]

Comment on attachment 352575 [details] [diff] [review]
allow both FORCE_STATIC_LIB and FORCE_SHARED_LIB in the same makefile

build-list.pl should be fed the static library name: that scripts is how the static build knows what libraries to link up at the end, and presumably we want it to link with the static libs, not the shared libs

The OS/2 block appears to be creating a .def file, which only applies to dynamic libraries, so I think you want the shared library name there. r=me with those changes

Comment 4

[(not currently active) Ted Mielczarek]

Pushed:
http://hg.mozilla.org/mozilla-central/rev/73be1c836d7f

Comment 5

[(not currently active) Ted Mielczarek]

This got backed out for win32 build bustage.

Comment 6

[(not currently active) Ted Mielczarek]

Attachment: interdiff to updated patch

I'm going to re-land this, I made one change to update a change I made in bug 467271. (And one comment change.)

Comment 7

[(not currently active) Ted Mielczarek]

Relanded in m-c:
http://hg.mozilla.org/mozilla-central/rev/a940f7f8b4b8

Comment 8

[Robert Strong (they/them - no direct email)]

It appears that this caused bug 473760

With changeset ae21c96c4355 the default browser check as well as the following works

Components.classes["@mozilla.org/browser/shell-service;1"].getService(Components.interfaces.nsIShellService);

With changeset 19e319a0647b neither works.

This only affects builds after they have been packages and not when they are run from dist/bin

Comment 9

[Robert Strong (they/them - no direct email)]

btw: I'm taking tomorrow off and won't be back until Tuesday so I won't be able to help fix bug 473760 anytime soon

Comment 10

[Marco Bonardo [:mak]]

could have caused also bug 473760, bug 473814, bug 473929

Comment 11

[(not currently active) Ted Mielczarek]

All symptoms of the same bug.