Closed Bug 471336 Opened 16 years ago Closed 15 years ago

ctrl key activated drag and drop folders within folder pane has wrong icon

Categories

(Thunderbird :: Mail Window Front End, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 3.0b3

People

(Reporter: philbaseless-firefox, Assigned: philbaseless-firefox)

References

Details

(Keywords: regression)

Attachments

(1 file, 2 obsolete files)

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.0.5) Gecko/2008120122 Firefox/3.0.5 (.NET CLR 3.5.30729)
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1b3pre) Gecko/20081225 Shredder/3.0b2pre  

see steps and results

Reproducible: Always

Steps to Reproduce:
1.in folderpane hold ctrl and drag and drop folder to another folder.
2.
3.
Actual Results:  
'+' icon for copy is shown
folder is moved

Expected Results:  
As in TB2
forbidden icon should show
nothing should happen.

I don't personally see the need for folder copy operations so I'd say the icon and action needs to be fixed.
Version: unspecified → Trunk
I don't know if it's supposed to copy with ctrl or not, anyway, there's a bug there. Confirming on linux/trunk.
Status: UNCONFIRMED → NEW
Component: General → Mail Window Front End
Ever confirmed: true
Keywords: regression
OS: Windows XP → All
QA Contact: general → front-end
Hardware: x86 → All
Rough regression window : between 20081109 and 20081125.

Quick test result of Ctrl+Drag(with holding down Ctrl) of a mail folder, using builds I happen to have.

> Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1b2pre) Gecko/20081109 Shredder/3.0b1pre
"forbidden icon" was displayed, as Tb2(and Tb1/Mozilla/Mozilla App Suite) did.

> Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1b2pre) Gecko/20081125 Shredder/3.0b1pre
"+ icon" was displayed.
Regression window: 2008-11-12 -> 2008-11-15

http://hg.mozilla.org/comm-central/pushloghtml?startdate=2008-11-12+03%3A00%3A00&enddate=2008-11-15+03%3A00%3A00

Non-rdf folder pane (bug 414038) landing in that time frame doesn't sound like a coincidence.
Blocks: 414038
copy of folders is canceled based on same criteria as 'drop'

re: http://mxr.mozilla.org/comm-central/source/mail/base/content/folderPane.js#440
Assignee: nobody → philbaseless-firefox
Status: NEW → ASSIGNED
Attachment #366752 - Flags: review?(mkmelin+mozilla)
it appears from the reference in my comment 4 that if the selected folder and target folder have same server it can't be copied and if they are different then they can't be moved.  I'm not that familiar the purpose.
If this is correct then the patch needs to be revised to show forbidden on move operations between folders with different servers.
Yeah that's how it supposed to work: if you drag a folder within the same server the folder should move. If you drag it to another server we make a copy of the folder.

Please also make the comment a proper sentence like the other comments around it, and the parenthesis pairs seem a bit unnecessary.
revised to comply with review comments
Attachment #366752 - Attachment is obsolete: true
Attachment #367412 - Flags: review?(mkmelin+mozilla)
Attachment #366752 - Flags: review?(mkmelin+mozilla)
Comment on attachment 367412 [details] [diff] [review]
move only within same server--copy only between different servers

The icons seem ok with this.

Unfortunately, dragging a folder to another account without holding ctrl doesn't work at all.
Per comment 6 only copy is allowed (ctrl key activated) between accounts. And copy (ctrl key) is not allowed within same folder. That should be consistent with comment 8.

I can get this to happen on local accounts but I can't get a folder to copy over to an IMAP folder.
(In reply to comment #9)
> Per comment 6 only copy is allowed (ctrl key activated) between accounts. And
> copy (ctrl key) is not allowed within same folder. That should be consistent
> with comment 8.

It's always a copy for drags between accounts, but user's haven't needed to have ctrl pressed to do that. 

Maybe we should change the (old) behavior so that normal drag between accounts will move, and ctrl+drag will copy?
This patch would make the icons act like TBird 2 which conforms to review comment.
Attachment #367412 - Attachment is obsolete: true
Attachment #368818 - Flags: review?(mkmelin+mozilla)
Attachment #367412 - Flags: review?(mkmelin+mozilla)
Comment on attachment 368818 [details] [diff] [review]
folder drop icons same as Thunderbird 2

Looks good, thx! r=mkmelin
Attachment #368818 - Flags: review?(mkmelin+mozilla) → review+
Keywords: checkin-needed
(In reply to comment #9)
> but I can't get a folder to copy over to an IMAP folder.

Bug 484784?
Checked in: http://hg.mozilla.org/comm-central/rev/faca790dfd20
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 3.0b3
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: