471336 - ctrl key activated drag and drop folders within folder pane has wrong icon

Status: RESOLVED FIXED

(Thunderbird :: Mail Window Front End, defect)

Description

[Phil Lacy]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.0.5) Gecko/2008120122 Firefox/3.0.5 (.NET CLR 3.5.30729)
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1b3pre) Gecko/20081225 Shredder/3.0b2pre  

see steps and results

Reproducible: Always

Steps to Reproduce:
1.in folderpane hold ctrl and drag and drop folder to another folder.
2.
3.
Actual Results:  
'+' icon for copy is shown
folder is moved

Expected Results:  
As in TB2
forbidden icon should show
nothing should happen.

I don't personally see the need for folder copy operations so I'd say the icon and action needs to be fixed.

Comment 1

[Magnus Melin [:mkmelin]]

I don't know if it's supposed to copy with ctrl or not, anyway, there's a bug there. Confirming on linux/trunk.

Comment 2

[WADA:World Anti-bad-Duping Agency]

Rough regression window : between 20081109 and 20081125.

Quick test result of Ctrl+Drag(with holding down Ctrl) of a mail folder, using builds I happen to have.

> Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1b2pre) Gecko/20081109 Shredder/3.0b1pre
"forbidden icon" was displayed, as Tb2(and Tb1/Mozilla/Mozilla App Suite) did.

> Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1b2pre) Gecko/20081125 Shredder/3.0b1pre
"+ icon" was displayed.

Comment 3

[Magnus Melin [:mkmelin]]

Regression window: 2008-11-12 -> 2008-11-15

http://hg.mozilla.org/comm-central/pushloghtml?startdate=2008-11-12+03%3A00%3A00&enddate=2008-11-15+03%3A00%3A00

Non-rdf folder pane (bug 414038) landing in that time frame doesn't sound like a coincidence.

Comment 4

[Phil Lacy]

Attachment: cancels copy of folders where drop is not allowed

copy of folders is canceled based on same criteria as 'drop'

re: http://mxr.mozilla.org/comm-central/source/mail/base/content/folderPane.js#440

Comment 5

[Phil Lacy]

it appears from the reference in my comment 4 that if the selected folder and target folder have same server it can't be copied and if they are different then they can't be moved.  I'm not that familiar the purpose.
If this is correct then the patch needs to be revised to show forbidden on move operations between folders with different servers.

Comment 6

[Magnus Melin [:mkmelin]]

Yeah that's how it supposed to work: if you drag a folder within the same server the folder should move. If you drag it to another server we make a copy of the folder.

Please also make the comment a proper sentence like the other comments around it, and the parenthesis pairs seem a bit unnecessary.

Comment 7

[Phil Lacy]

Attachment: move only within same server--copy only between different servers

revised to comply with review comments

Comment 8

[Magnus Melin [:mkmelin]]

Comment on attachment 367412 [details] [diff] [review]
move only within same server--copy only between different servers

The icons seem ok with this.

Unfortunately, dragging a folder to another account without holding ctrl doesn't work at all.

Comment 9

[Phil Lacy]

Per comment 6 only copy is allowed (ctrl key activated) between accounts. And copy (ctrl key) is not allowed within same folder. That should be consistent with comment 8.

I can get this to happen on local accounts but I can't get a folder to copy over to an IMAP folder.

Comment 10

[Magnus Melin [:mkmelin]]

(In reply to comment #9)
> Per comment 6 only copy is allowed (ctrl key activated) between accounts. And
> copy (ctrl key) is not allowed within same folder. That should be consistent
> with comment 8.

It's always a copy for drags between accounts, but user's haven't needed to have ctrl pressed to do that. 

Maybe we should change the (old) behavior so that normal drag between accounts will move, and ctrl+drag will copy?

Comment 11

[Phil Lacy]

Attachment: folder drop icons same as Thunderbird 2

This patch would make the icons act like TBird 2 which conforms to review comment.

Comment 12

[Magnus Melin [:mkmelin]]

Comment on attachment 368818 [details] [diff] [review]
folder drop icons same as Thunderbird 2

Looks good, thx! r=mkmelin

Comment 13

[WADA:World Anti-bad-Duping Agency]

(In reply to comment #9)
> but I can't get a folder to copy over to an IMAP folder.

Bug 484784?

Comment 14

[Mark Banner (:standard8)]

Checked in: http://hg.mozilla.org/comm-central/rev/faca790dfd20