471865 - Bookmark properties dialog mispositioned

Status: VERIFIED FIXED

(Firefox :: Theme, defect)

Description

[Wesley Johnston (:wesj)]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.2a1pre) Gecko/20081230 Firefox/3.1b1pre (.NET CLR 3.5.30729)
Build Identifier: 

The bookmark properties dialog is positioned to far to the left on OSX.

Reproducible: Always

Steps to Reproduce:
1.
2.
3.

Comment 1

[Wesley Johnston (:wesj)]

Attachment: Screenshot of problem

Comment 2

[Marco Bonardo [:mak]]

a regression range would be cool

Comment 3

[Wesley Johnston (:wesj)]

Seems to have happened between:

12/19 - ftp://ftp.mozilla.org/pub/firefox/nightly/2008/12/2008-12-19-02-mozilla-central/

12/20 - ftp://ftp.mozilla.org/pub/firefox/nightly/2008/12/2008-12-20-02-mozilla-central/

Here's the changeset as best I know how to get it:

http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=eb8abab83036&tochange=050ae62b7d9d

Comment 4

[Dão Gottwald [:dao]]

Bug 279539 is in the range...

Comment 5

[Markus Stange [:mstange]]

Yeah, bug 279539 seems very likely. In bug 462650 I used margin-right to position #editBookmarkPanel because margin-left didn't work - maybe that's fixed now?

Comment 6

[Marco Bonardo [:mak]]

this sounds quite visible, asking blocking to put this on drivers' radar, even if from a functionality point of view it will not block anything.

Comment 7

[Henrik Skupin [:whimboo][⌚️UTC+2] (away 02/17 - 02/21)]

Yes, I run into that problem while testing the tryserver build on bug 413053.

Comment 8

[Markus Stange [:mstange]]

Attachment: fix

Enn, is this the right fix?

Comment 9

[Neil Deakin]

Is 27 pixels the distance between the arrow point and the star icon?

Comment 10

[Markus Stange [:mstange]]

It's the distance between the right edge of the star icon and the right edge of the panel shadow (when the panel is at the intended position).

That is, the panel's right edge is 27px right of the star icon.

Comment 11

[Markus Stange [:mstange]]

It's the distance between the right edge of the star icon and the right edge of the panel shadow (when the panel is at the intended position).

That is, the panel's right edge is 27px right of the star icon.

Comment 12

[Neil Deakin]

Comment on attachment 355824 [details] [diff] [review]
fix

OK, I think that's what I meant to ask.

Comment 13

[Markus Stange [:mstange]]

Removing the blocking request - Bug 279539 hasn't landed on 1.9.1 yet, so this bug probably doesn't even exist in 3.1.

Comment 14

[Markus Stange [:mstange]]

http://hg.mozilla.org/mozilla-central/rev/82a898e520fe

Comment 15

[Henrik Skupin [:whimboo][⌚️UTC+2] (away 02/17 - 02/21)]

Verified with Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.2a1pre) Gecko/20090118 Minefield/3.2a1pre ID:20090118020617