462650 - HUD panels: add half diamond arrow on the top of the panel

Status: VERIFIED FIXED

(Firefox :: Theme, defect)

Description

[Alex Faaborg [:faaborg] (Firefox UX)]

Attachment: Half diamond arrow on top of a HUD panel

We should add a half diamond arrow on top of the HUD panels in Firelight (site identity, bookmark information).  Attached is a rough mockup, this is similar to the contextual menu on dock items, but with the HUD appearance.

The windows counterpart to this is bug 413059, where there is an example patch using SVG instead of -moz-border-image, which might be worth taking a look at.  Since we don't have to worry about adapting the appearance of the panel for different OS themes, that approach might be overkill.

Comment 1

[Markus Stange [:mstange]]

Attachment: border-image for panel

Comment 2

[Markus Stange [:mstange]]

Attachment: Screenshot: Site identity HUD panel

Comment 3

[Markus Stange [:mstange]]

Attachment: Screenshot: bookmarks HUD panel

Comment 4

[Markus Stange [:mstange]]

I'm not really sure yet if we should really use that gradient at the top of the panel; unlike all the other HUD panels in OS X, our panels don't have a real titlebar. Moreover, the gradient collides with the bookmarks bar gradient in a weird way.

Comment 5

[Alex Faaborg [:faaborg] (Firefox UX)]

>I'm not really sure yet if we should really use that gradient at the top of the
>panel

Yeah I agree, these will work better without the title bar gradient.

Comment 6

[Alex Faaborg [:faaborg] (Firefox UX)]

Comment on attachment 345975 [details]
Screenshot: Site identity HUD panel

ui-r+ with the gradient removed from the title bar, size and placement of the half diamond looks good

Comment 7

[Alex Faaborg [:faaborg] (Firefox UX)]

Comment on attachment 345976 [details]
Screenshot: bookmarks HUD panel

ui-r+ with the gradient removed from the title bar, size and placement of the half diamond looks good

Comment 8

[Markus Stange [:mstange]]

Attachment: new border image

Comment 9

[Markus Stange [:mstange]]

Attachment: patch v1

Comment 10

[Markus Stange [:mstange]]

Attachment: v1.1, image included

Comment 11

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 346041 [details] [diff] [review]
v1.1, image included

r=beltzner

Comment 12

[Neil Deakin]

This of course is going to completely fail if the window is near the edge of the screen, no?

Comment 13

[Markus Stange [:mstange]]

Oh, yeah... but these panels pop up towards the center of the window, so it's only an issue if the window overlaps the edges of the screen, right?

Comment 14

[Alex Faaborg [:faaborg] (Firefox UX)]

>This of course is going to completely fail if the window is near the edge of
>the screen, no?

Is there any way to remove the arrow in the case that the panel is being draw in a different position to avoid being drawn off screen?  Ideally we could add all sorts of extra logic so we could get the arrow in a variety of positions, like when you right click on a link and say "bookmark this link."  But that is of course some significant scope creep.

Comment 15

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 346041 [details] [diff] [review]
v1.1, image included

a191=beltzner - please test thoroughly after landing and be ready to back out if, as Enn warns, the edge cases overtake the value of this patch.

Comment 16

[Shawn Wilsher :sdwilsh]

http://hg.mozilla.org/mozilla-central/rev/960b97b64485

Comment 17

[Aakash Desai [:aakashd]]

Yeah, so the attached screenshot shows behavior when the window is close enough to the bottom of the screen that there isn't enough room to keep the HUD panel at the bottom of the button.

Comment 18

[Aakash Desai [:aakashd]]

Attachment: HUD panel issue when Browser at Bottom of Screen ScreenShot

Comment 19

[Aakash Desai [:aakashd]]

A bug has been created for this issue with a better screenshot attached to the bug.

Bug link: https://bugzilla.mozilla.org/show_bug.cgi?id=495140

HUD Panel has diamond arrow on both builds:

Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.2a1pre) Gecko/20090527 Minefield/3.6a1pre ID:20090527031500

and

Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.1pre) Gecko/20090527 Shiretoko/3.5pre ID:20090527031214