47191 - images fail to display if name is prefixed with space in double quotes

Status: VERIFIED FIXED

(Core :: DOM: HTML Parser, defect, P3)

Description

[ekrock's old account (dead)]

Using Commercial 2000080104 on WinNT 4.0 SP4.

To repro:
1) view page in Seamonkey; in table in middle of page, you see the *names* of
four images, not the images themselves
2) view in Nav4 -- looks fine

The problem: in the HTML source, in the double quotes for the name of the image
file, the page author has included an extraneous space prior to the image name.
Nav4 clearly had sympathetic parsing for this (which we'd do well to match!);
apparently we don't.

Here's the offending markup:

<CENTER><TABLE BORDER CELLSPACING=2 BORDERCOLOR="#000000" WIDTH=450>
<TR><TD WIDTH="50%" VALIGN="MIDDLE">
<P>&nbsp;<IMG SRC=" newmemsmall.gif" WIDTH=310 HEIGHT=174></TD>
<TD WIDTH="50%" VALIGN="MIDDLE">
<P>&nbsp;<IMG SRC=" newmem2small.gif" WIDTH=310 HEIGHT=174></TD>
</TR>
<TR><TD WIDTH="50%" VALIGN="MIDDLE">
<P>&nbsp;<IMG SRC=" newmem3small.gif" WIDTH=310 HEIGHT=174></TD>
<TD WIDTH="50%" VALIGN="MIDDLE">
<P>&nbsp;<IMG SRC=" newmem4small.gif" WIDTH=310 HEIGHT=174></TD>
</TR>
</TABLE>
</CENTER>

Note spaces prior to GIF names. (Checked View Source in Nav4 to make sure this
wasn't a VS display bug; it's not.)

Comment 1

[ekrock's old account (dead)]

Nom. for nsbeta3 consideration as a correctness (e.g. 4xp) bug for existing
markup. But we can future if lacking time; after all, the workaround is
(presumably) to fix markup to drop the space.

Comment 2

[ekrock's old account (dead)]

Final comment: don't take the fact that I've nominated this for nsbeta3
consideration to mean that I strongly think we must fix this before RTM. I
don't, unless we find lots of top100 pages that break because of this. This bug
falls into the category of "if it's easy and the engineer has the cycles, we'd
love to fix this, but we can FUTURE this easily if not."

Comment 3

[Hixie (not reading bugmail)]

Note to anyone planning to mark this INVALID -- spaces at the start and end of
content in CDATA attributes should be ignored per the spec, so this is valid.
It's also a minor issue...

Comment 4

[harishd]

Triaging rickg's bug list:

This is not a parser issue. Parser just consumes everyting between quotes.  The 
problem should be addressed in layout. Giving bug to waterson and ccing 
nisheeth and myself.

Comment 5

[Chris Waterson]

this is a break-the-web problem. should be straight-forward to fix: strip off
whitespace before using attribute somewhere.

Comment 6

[Chris Waterson]

Attaching fix, which was to add string.Trim(" \n\r") at appropriate times before
calling NS_MakeAbsoluteURI() or NS_NewURI().

Comment 7

[Chris Waterson]

Attachment: trim whitespace before creating absolute URI

Comment 8

[Chris Waterson]

fix checked in. per jst's suggestion use " \t\r\n", not just " \r\n", as the
characters to trim.

Comment 9

[Heikki Toivonen (remove -bugzilla when emailing directly)]

Verified on NT & Linux, this week's builds.