472386 - Port |Bug 291341 - switching from drafts folder to saved search folder does not remove "Edit Draft..." button| to SeaMonkey

Status: RESOLVED FIXED

(SeaMonkey :: MailNews: Message Display, defect)

Description

[Jens Hatlak (:InvisibleSmiley)]

While going through the bugs for my next blog post I stumbled over Bug 375381 comments 5 and 8:
"(And in fact, SeaMonkey does not show the Edit button in this case.)"
"You don't see it in SeaMonkey because SM didn't get bug 291341's switch from a
global that's only set to true in msgMail3PaneWindow.js to looking at the
draftiness of the msg's folder, whether or not it's currently being displayed
in that or any folder."

This bug is for porting that. Guess who I'll ask for review... ;-)

Patch coming up.

Comment 1

[Jens Hatlak (:InvisibleSmiley)]

Attachment: Patch fixing bug 291341 and bug 375381 for SM

Comment 2

[Karsten Düsterloh]

Comment on attachment 355664 [details] [diff] [review]
Patch fixing bug 291341 and bug 375381 for SM

Looks good.

Comment 3

[[e-mail]]

Comment on attachment 355664 [details] [diff] [review]
Patch fixing bug 291341 and bug 375381 for SM

[I don't see anything relevant to bug 375381 in this patch.]

>+  var msgHdr;
>+  try
>+  {
>+    msgHdr = gDBView.hdrForFirstSelectedMessage;
>+  }
>+  catch (ex)
>+  {
>+    return;
>+  }
>+  const nsMsgFolderFlags = Components.interfaces.nsMsgFolderFlags;
>+  if (IsSpecialFolder(msgHdr.folder, nsMsgFolderFlags.Drafts, true))
>+    document.getElementById("editMessageBox").collapsed = false;
I would put all of the code inside the try block, thus avoiding the separate var msgHdr and return, although I'm not sure Mnyromyr would like that.

Comment 4

[Karsten Düsterloh]

> I would put all of the code inside the try block, thus avoiding the separate
> var msgHdr and return, although I'm not sure Mnyromyr would like that.

Fine by me...

Comment 5

[Jens Hatlak (:InvisibleSmiley)]

Attachment: Patch v2, sr=neil [Checkin: Comment 6]

(In reply to comment #3)
> (From update of attachment 355664 [details] [diff] [review])
> [I don't see anything relevant to bug 375381 in this patch.]

True. I just wanted to express that Edit Draft will also work with standalone windows in SM when this bug is fixed.

> I would put all of the code inside the try block, thus avoiding the separate
> var msgHdr and return

Done. Re-requesting review just to be sure.

Comment 6

[Serge Gautherie (:sgautherie)]

Comment on attachment 357691 [details] [diff] [review]
Patch v2, sr=neil
[Checkin: Comment 6]


http://hg.mozilla.org/comm-central/rev/494adf308547