Closed Bug 473217 Opened 15 years ago Closed 15 years ago

archive command doesn't work in rss feeds

Categories

(Thunderbird :: Mail Window Front End, defect)

x86
Windows XP
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 3.0b2

People

(Reporter: Bienvenu, Assigned: Bienvenu)

References

(Blocks 1 open bug)

Details

(Whiteboard: [has patch for review])

Attachments

(1 file)

According to Standard8, the archive button doesn't work in rss feeds. Instead of disabling it, I thing we should make it work like the local folders account it is...
Blocks: 473212
marking blocking b2
Flags: blocking-thunderbird3+
Whiteboard: [should be easy]
Target Milestone: --- → Thunderbird 3.0b2
archiving rss feeds puts messages in the local folder archive, which means that we're not getting an archives folder for the rss account from prefs, and are using the local folders archive folder. I'm assuming we want an Archives folder in the rss account itself.
Do people want to archive RSS feeds?  I'm guessing so from the bug, but my first thought was wondering why the button appeared for an rss feed.
I can see wanting to save particular  rss messages...

looking at the code, I think the cause of this bug is that rss servers have no identities, so the code falls back onto the local folder, but I'll have to debug it to be sure.
Status: NEW → ASSIGNED
Attached patch proposed fixSplinter Review
since the rss account doesn't have an identity, we just create an Archives folder URI directly.
Attachment #359188 - Flags: review?(bugzilla)
Whiteboard: [should be easy] → [has patch for review]
Comment on attachment 359188 [details] [diff] [review]
proposed fix

>-      let archiveFolderUri =
>-        getIdentityForHeader(msgs[0], Components.interfaces.nsIMsgCompType.ReplyAll).archiveFolder;
>+      let archiveFolderUri;
>+      // rss servers don't have an identity so we special case the archives URI
>+      archiveFolderUri = (srcFolder.server.type == 'rss')
>+        ? srcFolder.server.serverURI + "/Archives"
>+        : getIdentityForHeader(msgs[0], Components.interfaces.nsIMsgCompType
>+                                        .ReplyAll).archiveFolder;

Might as well keep the let on the same line as the assignment I think.

r=me with that fixed. Though also requesting ui-review just to make sure Bryan's happy with this.
Attachment #359188 - Flags: ui-review?(clarkbw)
Attachment #359188 - Flags: review?(bugzilla)
Attachment #359188 - Flags: review+
Attachment #359188 - Flags: ui-review?(clarkbw) → ui-review+
Comment on attachment 359188 [details] [diff] [review]
proposed fix

looks good, follows a very similar pattern to the rest of the archives system.

I'm also assuming that viewing rss entries in the archives will work in the expected manner.
yes, viewing rss entries should behave like it does in any rss folder. fix checked in.
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.