473217 - archive command doesn't work in rss feeds

Status: RESOLVED FIXED

(Thunderbird :: Mail Window Front End, defect)

Description

[David :Bienvenu]

According to Standard8, the archive button doesn't work in rss feeds. Instead of disabling it, I thing we should make it work like the local folders account it is...

Comment 1

[David :Bienvenu]

marking blocking b2

Comment 2

[David :Bienvenu]

archiving rss feeds puts messages in the local folder archive, which means that we're not getting an archives folder for the rss account from prefs, and are using the local folders archive folder. I'm assuming we want an Archives folder in the rss account itself.

Comment 3

[Bryan Clark (DevTools PM) [:clarkbw]]

Do people want to archive RSS feeds?  I'm guessing so from the bug, but my first thought was wondering why the button appeared for an rss feed.

Comment 4

[David :Bienvenu]

I can see wanting to save particular  rss messages...

looking at the code, I think the cause of this bug is that rss servers have no identities, so the code falls back onto the local folder, but I'll have to debug it to be sure.

Comment 5

[David :Bienvenu]

Attachment: proposed fix

since the rss account doesn't have an identity, we just create an Archives folder URI directly.

Comment 6

[Mark Banner (:standard8)]

Comment on attachment 359188 [details] [diff] [review]
proposed fix

>-      let archiveFolderUri =
>-        getIdentityForHeader(msgs[0], Components.interfaces.nsIMsgCompType.ReplyAll).archiveFolder;
>+      let archiveFolderUri;
>+      // rss servers don't have an identity so we special case the archives URI
>+      archiveFolderUri = (srcFolder.server.type == 'rss')
>+        ? srcFolder.server.serverURI + "/Archives"
>+        : getIdentityForHeader(msgs[0], Components.interfaces.nsIMsgCompType
>+                                        .ReplyAll).archiveFolder;

Might as well keep the let on the same line as the assignment I think.

r=me with that fixed. Though also requesting ui-review just to make sure Bryan's happy with this.

Comment 7

[Bryan Clark (DevTools PM) [:clarkbw]]

Comment on attachment 359188 [details] [diff] [review]
proposed fix

looks good, follows a very similar pattern to the rest of the archives system.

I'm also assuming that viewing rss entries in the archives will work in the expected manner.

Comment 8

[David :Bienvenu]

yes, viewing rss entries should behave like it does in any rss folder. fix checked in.