47356 - nsDirectoryIndexStream is not thread-safe

Status: RESOLVED FIXED

(Core :: Networking: File, defect, P3)

Description

[Randell Jesup [:jesup] (needinfo me)]

Got this while trying to go to file:///tmp

#0  nsDebug::Assertion (
    aStr=0x28da84e0 "nsDirectoryIndexStream not thread-safe", 
    aExpr=0x281e8b60 "owningThread == NS_CurrentThread()", 
    aFile=0x281e8b42 "nsDebug.cpp", aLine=436) at nsDebug.cpp:184
#1  0x2818bca8 in NS_CheckThreadSafe (owningThread=0x83e4180, 
    msg=0x28da84e0 "nsDirectoryIndexStream not thread-safe") at nsDebug.cpp:436
#2  0x28cfa3ec in nsDirectoryIndexStream::Release (this=0x9170f00)
    at nsDirectoryIndexStream.cpp:114
#3  0x80574e9 in nsCOMPtr<nsIInputStream>::assign_assuming_AddRef (
    this=0x8934358, newPtr=0x0) at ../../dist/include/nsCOMPtr.h:471
#4  0x281bf9e5 in nsCOMPtr<nsIInputStream>::assign_with_AddRef (this=0x8934358, 
    rawPtr=0x0) at ../../../../dist/include/nsCOMPtr.h:848
#5  0x281bfc1d in nsCOMPtr<nsIInputStream>::operator= (this=0x8934358, rhs=0x0)
    at ../../../../dist/include/nsCOMPtr.h:583
#6  0x28ce941c in nsFileTransport::Process (this=0x8934300)
    at nsFileTransport.cpp:503
#7  0x28ce8a6d in nsFileTransport::Run (this=0x8934300)
    at nsFileTransport.cpp:351
#8  0x281853cb in nsThreadPoolRunnable::Run (this=0x8a1f2d0) at nsThread.cpp:689
#9  0x2818300d in nsThread::Main (arg=0x8a36500) at nsThread.cpp:84
#10 0x282ed271 in _pt_root (arg=0x89e5a00) at ptthread.c:157
#11 0x28336a5e in _thread_start () from /usr/lib/libc_r.so.3
#12 0x0 in ?? ()

Comment 1

[Randell Jesup [:jesup] (needinfo me)]

Reconfirmed with fresh pull 8/21/00.

Comment 2

[Randell Jesup [:jesup] (needinfo me)]

Attachment: Another more extensive backtrace

Comment 3

[Randell Jesup [:jesup] (needinfo me)]

See also bug 49813

Comment 4

[Randell Jesup [:jesup] (needinfo me)]

After checking a little more on non-thread-safe issues, I'm raising this to 
Major.  thread-safety issues could cause crashes and/or data

Comment 5

[Blake Ross]

Missed the 0.9.3 train.

Comment 6

[Judson Valeski]

and 0.9.4

Comment 7

[rpotts (gone)]

-> 0.9.6

Comment 8

[rpotts (gone)]

-> 1.0

Comment 9

[Asa Dotzler [:asa]]

Bugs targeted at mozilla1.0 without the mozilla1.0 keyword moved to mozilla1.0.1 
(you can query for this string to delete spam or retrieve the list of bugs I've 
moved)

Comment 10

[Hixie (not reading bugmail)]

Moving all threading bugs to XPCOM. See bug 160356.

Comment 11

[Vedran Miletic]

retargeting

Comment 12

[timeless]

per bug 160356 comment 3 this is an impl issue

Comment 13

[Randell Jesup [:jesup] (needinfo me)]

This got changed somewhere along the way from NS_DECL_ISUPPORTS to NS_DECL_THREADSAFE_ISUPPORTS, so closing.