Closed Bug 473661 Opened 11 years ago Closed 11 years ago

Use popupshowing event to hook Lightning into mailContext menus

Categories

(Calendar :: Lightning Only, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: iann_bugzilla, Assigned: iann_bugzilla)

Details

Attachments

(1 file)

It has been pointed out over in bug 473011 that a better way of hooking into the context menus is to use the popupshowing event instead of observing notifyObservers.
Advantage of this method is that:
* No changes needed to TB or SM to hook in Lightning.
Attachment #357042 - Flags: review?(Berend.Cornelius)
Comment on attachment 357042 [details] [diff] [review]
Remove observer and add popupshowing event listener patch v0.1

Hopefully this will be the final change to hook into TB/SM
Comment on attachment 357042 [details] [diff] [review]
Remove observer and add popupshowing event listener patch v0.1

patch looks very good. Yet I think that the code is better placed in messenger-overlay-toolbar.js where the convert-menu is also defined. I know of course that I should have mentioned this already in the review of Bug 473012 - Get Lightning to use nsIObserver for overlaying mailContext menus. The naming "messenger-overlay-toolbar" should of course als be changed someday in this respect.
Attachment #357042 - Flags: review?(Berend.Cornelius) → review+
patch pushed to comm-central:

http://hg.mozilla.org/comm-central/rev/4650662557d9

->fixed
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → 1.0
The last patch lead to output on the errorconsole because of a redeclaration of gCalSetupMailContext, obviously because the js-file was loaded twice.

pushed a second patch to commm-centra with r-overtheshoulde=philipp:

http://hg.mozilla.org/comm-central/rev/5359aa4cf851

->fixed
in reply to comment #6:
done:
http://hg.mozilla.org/comm-central/rev/eda7cfd1ccf3

Thank you for the hint
These bugs are likely targeted at Lightning 1.0b1, not Lightning 1.0. If this change was done in error, please adjust the target milestone to its correct value. To filter on this bugspam, you can use "lightning-10-target-move".
Target Milestone: 1.0 → 1.0b1
You need to log in before you can comment on or make changes to this bug.