473661 - Use popupshowing event to hook Lightning into mailContext menus

Status: RESOLVED FIXED

(Calendar :: Lightning Only, defect)

Description

[Ian Neal]

It has been pointed out over in bug 473011 that a better way of hooking into the context menus is to use the popupshowing event instead of observing notifyObservers.

Comment 1

[Ian Neal]

Attachment: Remove observer and add popupshowing event listener patch v0.1

Advantage of this method is that:
* No changes needed to TB or SM to hook in Lightning.

Comment 2

[Ian Neal]

Comment on attachment 357042 [details] [diff] [review]
Remove observer and add popupshowing event listener patch v0.1

Hopefully this will be the final change to hook into TB/SM

Comment 3

[Berend Cornelius]

Comment on attachment 357042 [details] [diff] [review]
Remove observer and add popupshowing event listener patch v0.1

patch looks very good. Yet I think that the code is better placed in messenger-overlay-toolbar.js where the convert-menu is also defined. I know of course that I should have mentioned this already in the review of Bug 473012 - Get Lightning to use nsIObserver for overlaying mailContext menus. The naming "messenger-overlay-toolbar" should of course als be changed someday in this respect.

Comment 4

[Berend Cornelius]

patch pushed to comm-central:

http://hg.mozilla.org/comm-central/rev/4650662557d9

->fixed

Comment 5

[Berend Cornelius]

The last patch lead to output on the errorconsole because of a redeclaration of gCalSetupMailContext, obviously because the js-file was loaded twice.

pushed a second patch to commm-centra with r-overtheshoulde=philipp:

http://hg.mozilla.org/comm-central/rev/5359aa4cf851

->fixed

Comment 6

[Simon Paquet [:sipaq]]

Berend, could you please remove the obsolete comment in http://hg.mozilla.org/comm-central/file/5359aa4cf851/calendar/base/content/calendar-chrome-startup.js#l68 as well?

Comment 7

[Berend Cornelius]

in reply to comment #6:
done:
http://hg.mozilla.org/comm-central/rev/eda7cfd1ccf3

Thank you for the hint

Comment 8

[Philipp Kewisch [:Fallen][📱📆]]

These bugs are likely targeted at Lightning 1.0b1, not Lightning 1.0. If this change was done in error, please adjust the target milestone to its correct value. To filter on this bugspam, you can use "lightning-10-target-move".