473734 - Switch matchOnlyTyped to restrict.typed "~" (default.behavior + 32)

Status: VERIFIED FIXED

(SeaMonkey :: Location Bar, defect)

Description

[Robert Kaiser]

We need to do the same as bug 463483 for SeaMonkey, meaning another adjustment to UI prefs as well.

Due to restrict.typed missing in our default prefs (bug 472603 will improve that situation in the future), we're currently failing unit tests that rely on this, originally reported as bug 472978 but I'll dupe it here as the work in this bug will fix them.

Comment 2

[Robert Kaiser]

Attachment: switch to new pref(s)

Here's the fix for this one, and now it really makes sense that those pref sync functions hand over aField ;-)

Comment 4

[[e-mail]]

Comment on attachment 357124 [details] [diff] [review]
switch to new pref(s)

>-pref("browser.urlbar.matchOnlyTyped", false);
Is there a bug for migrating to places prefs?

>+    document.getElementById("matchOnlyURLs").disabled = matchDisabled;
>     document.getElementById("matchOnlyTyped").disabled = matchDisabled;
IMHO Typed belongs before URLs

>+  // Return the right bit based on the id of "aField"
Hmm, might be better to have
const kBehaviourBit = {
  matchOnlyURLs: 16,
  matchOnlyTyped: 32
};
then use kBehaviourBit[aField.id]

Comment 5

[Robert Kaiser]

(In reply to comment #4)
> (From update of attachment 357124 [details] [diff] [review])
> >-pref("browser.urlbar.matchOnlyTyped", false);
> Is there a bug for migrating to places prefs?

You mean on profile migration? I don't know of any...

> >+    document.getElementById("matchOnlyURLs").disabled = matchDisabled;
> >     document.getElementById("matchOnlyTyped").disabled = matchDisabled;
> IMHO Typed belongs before URLs

Easy to do :)

> >+  // Return the right bit based on the id of "aField"
> Hmm, might be better to have
> const kBehaviourBit = {
>   matchOnlyURLs: 16,
>   matchOnlyTyped: 32
> };
> then use kBehaviourBit[aField.id]

Sounds like a good idea as well :)

Comment 6

[Robert Kaiser]

Attachment: switch to new pref(s), v2

This patch is updated for Neil's previous comments.

Comment 7

[Robert Kaiser]

Pushed as http://hg.mozilla.org/comm-central/rev/cd9d93b62fd0

Comment 8

[Serge Gautherie (:sgautherie)]

V.Fixed, "per" bug 472978 tests.