474026 - Remove lists that use native frames

Status: RESOLVED INVALID

(Firefox for Android Graveyard :: General, defect)

Description

[Mark Finkle (:mfinkle) (use needinfo?)]

Widgets that create native frames have been shown to reduce performance. A frame-less widget should be created and used to implement scrollable and non-scrollable lists in Fennec.

Comment 1

[Mark Finkle (:mfinkle) (use needinfo?)]

Attachment: WIP 1: Removes native frames but doesn't fully support scrolling yet

This patch is the beginning. It adds a <richlistbox> into Fennec that does not use native frames. We also use this widget to replace the <scrollbox> used for preferences. So currently, this patch removes 3 native frames from Fennec.

Better support for scrolling is the next phase.

Comment 2

[Mark Finkle (:mfinkle) (use needinfo?)]

Attachment: WIP1.1: with the missing richlistbox.xml file

Adds the missing file to the patch

Comment 3

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 357421 [details] [diff] [review]
WIP1.1: with the missing richlistbox.xml file

Technically, this patch won't break anything in Fennec that isn't already broken. It does remove 3 native frames, which should help performance a little.

Asking for review. I can file a followup bug on adding the scrolling support.

Comment 4

[Mark Finkle (:mfinkle) (use needinfo?)]

we fixed the tablist via another patch and we don't want to remove richlistboxes from everywhere because they support panning for free

Comment 5

[Biju]

sorry for bug spam.
Many of the bugs which are marked invalid, I see comments telling it occurred in one version or other. But later it was fixed due to 1) by backingout the patch which made regression or 2) by fixing some other bug.
So if we can identify the bug/patch/reason then we should state that and mark those as FIXED. If not mark as WORKSFORME in that case.