474325 - Google calendars disabled on startup

Status: VERIFIED FIXED

(Calendar :: General, defect)

Description

[James Peterson]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.0.3) Gecko/2008092416 Firefox/3.0.3
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.1b3pre) Gecko/20090119 Lightning/1.0pre Shredder/3.0b2pre

[Exception... "Component returned failure code: 0x80570015
(NS_ERROR_XPC_CI_RETURNED_FAILURE) [nsIJSCID.createInstance]"  nsresult:
"0x80570015 (NS_ERROR_XPC_CI_RETURNED_FAILURE)"  location: "JS frame ::
file:///home/jamespet/.thunderbird/amxwosiz.Work/extensions/%7Be2fda1a4-762b-4020-b5ad-a41df1933103%7D/modules/calUtils.jsm
->
file:///home/jamespet/.thunderbird/amxwosiz.Work/extensions/%7Be2fda1a4-762b-4020-b5ad-a41df1933103%7D/calendar-js/calCalendarManager.js
:: cmgr_createCalendar :: line 520"  data: no]



Reproducible: Always

Steps to Reproduce:
1. Install lasted build of thunderbird. lightning, and gdata-provider
2. start thunderbird
3. google calendars produce startup exception
4. google calendars are disabled



This Error started after the fix for bug 473973 was completed and may be related.

Comment 1

[Mark Banner (:standard8)]

Confirming because I now see this - for my testing post bug 473973 I was using an hourly build (06 I think), I've just updated to the nightly build on the 18th, and it is now broken.

Hence this isn't a regression from bug 473973 but there are two bugs that it could be: bug 469477 or bug 474207 - hopefully I can narrow this down in a little while.

Comment 2

[Stefan Sitter [:ssitter]]

Trying to reproduce the issue resulted in the following error during calendar creation:

Error: SyntaxError: missing ; before statement (file:///.../js/calGoogleCalendar.js)
Source file: file:///.../modules/calUtils.jsm
Line: 78

followed by the one mentioned above.

Comment 3

[Philipp Kewisch [:Fallen][📱📆]]

Attachment: Fix - v1

Just a typo from bug 469477.

Comment 4

[Mark Banner (:standard8)]

Comment on attachment 357704 [details] [diff] [review]
Fix - v1

I've not tested it, but they sure are a problem.

Comment 5

[James Peterson]

Seems to work from this side.

Comment 6

[Philipp Kewisch [:Fallen][📱📆]]

Pushed to comm-central <http://hg.mozilla.org/comm-central/rev/6785834e804c>

-> FIXED

Comment 7

[Andreas Treumann]

Checked with lightning and sunbird build 20090126 -> VERIFIED.

Comment 8

[Philipp Kewisch [:Fallen][📱📆]]

These bugs are likely targeted at Lightning 1.0b1, not Lightning 1.0. If this change was done in error, please adjust the target milestone to its correct value. To filter on this bugspam, you can use "lightning-10-target-move".