474375 - Always save test files with .js extension even if none is given

Status: VERIFIED FIXED

(Testing Graveyard :: Mozmill, defect)

Description

[Aakash Desai [:aakashd]]

User-Agent:       Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.2a1pre) Gecko/20090104 Minefield/3.2a1pre
Build Identifier: Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.2a1pre) Gecko/20090104 Minefield/3.2a1pre

The user should be able to select and open a file that was saved as a test file by MozMill. This was only tried on OS X so far, so the determination as to whether this is an OS-specific issue is still possible. 

Reproducible: Always

Steps to Reproduce:
1. Select a "New Boilerplate" in the Tests Menu
2. Save the testfile
3. Go to Tests | Run Test File
4. In the opened selection window, try to click on the saved test file.
5. Click on cancel.
Actual Results:  
After step 4, the grayed-out selection cannot be highlighted and the "open" button cannot be pushed.

Expected Results:  
The saved test file should be selectable.

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+1]]

You probably don't have given an js extension for the test. That's why it is grayed and cannot be selected. I saw the same a while ago.

At least we should check the file extension when saving to a new file. It should always be .js, even if the user hasn't specified one.

Comment 2

[Adam Christian]

Committed revision 321. Forcing all save as files to have a .js file, if one isn't provided it is now appended.

Committed revision 321.

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Verified with latest trunk.