Closed
Bug 474417
Opened 17 years ago
Closed 17 years ago
[FIX]<wbr> support broken: treated like <br>
Categories
(Core :: Layout, defect)
Tracking
()
VERIFIED
FIXED
People
(Reporter: jmjjeffery, Assigned: bzbarsky)
References
Details
(Keywords: regression)
Attachments
(2 files, 1 obsolete file)
|
76.17 KB,
image/x-png
|
Details | |
|
2.62 KB,
patch
|
roc
:
review+
roc
:
superreview+
|
Details | Diff | Splinter Review |
Trunk Firefox + trunk ChatZilla
Chatzilla layout is broken again. The 'text/chat' window is only using 1/4 of the area and wrapping lines early not using the full area.
Regressed:
1/19/09 13:14hrs build OK
changeset: http://hg.mozilla.org/mozilla-central/rev/852f545cc9d1
1/19/09 13:45hrs build Bad
changeset: http://hg.mozilla.org/mozilla-central/rev/cc3b3a8f35cb
18 part checkin for https://bugzilla.mozilla.org/show_bug.cgi?id=473390
|
||
Comment 1•17 years ago
|
||
This is what you get with trunk Firefox and trunk ChatZilla currently - it is wrapping at every <html:wbr> tag, as best I can tell.
|
|
||
Updated•17 years ago
|
Hardware: x86 → All
|
Assignee | |
Comment 2•17 years ago
|
||
Er, yes. Totally my fault. I'd had this right in the initial patch versions, I thought...
In any case, fix + reftest for wbr coming up.
|
|
Assignee | |
Updated•17 years ago
|
Assignee: rginda → nobody
Component: ChatZilla → Layout: Misc Code
Product: Other Applications → Core
QA Contact: chatzilla → layout.misc-code
Summary: Chatzilla layout wrong → [FIX]<wbr> support broken: treated like <br>
|
|
Assignee | |
Updated•17 years ago
|
Assignee: nobody → bzbarsky
|
|
Assignee | |
Comment 3•17 years ago
|
||
Attachment #357793 -
Flags: superreview?(roc)
Attachment #357793 -
Flags: review?(roc)
|
|
Assignee | |
Comment 4•17 years ago
|
||
Comment on attachment 357793 [details] [diff] [review]
Fix
This test is no good, since the <wbr> actually affects the spacing between the A and B in the non-wrapping case (due to kerning? dunno)
Attachment #357793 -
Attachment is obsolete: true
Attachment #357793 -
Flags: superreview?(roc)
Attachment #357793 -
Flags: review?(roc)
|
|
Assignee | |
Comment 5•17 years ago
|
||
Attachment #357797 -
Flags: superreview?(roc)
Attachment #357797 -
Flags: review?(roc)
Attachment #357797 -
Flags: superreview?(roc)
Attachment #357797 -
Flags: superreview+
Attachment #357797 -
Flags: review?(roc)
Attachment #357797 -
Flags: review+
|
|
Assignee | |
Comment 6•17 years ago
|
||
Status: NEW → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
|
Reporter | |
Comment 8•17 years ago
|
||
Verified Fixed using build:
Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9.2a1pre) Gecko/20090120 Minefield/3.2a1pre Firefox/3.0.4 ID:20090120155340
changeset: http://hg.mozilla.org/mozilla-central/rev/a563bc0ec80a
Status: RESOLVED → VERIFIED
|
||
Updated•7 years ago
|
Product: Core → Core Graveyard
|
||
Updated•7 years ago
|
Component: Layout: Misc Code → Layout
Product: Core Graveyard → Core
You need to log in
before you can comment on or make changes to this bug.
Description
•