474598 - The icons on the toolbar should change or disappear depending on the tab selected

Status: RESOLVED FIXED

(Thunderbird :: Toolbars and Tabs, defect)

Description

[dave.r.wilson]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 6.0; en-GB; rv:1.9.0.5) Gecko/2008120122 Firefox/3.0.5
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 6.0; en-GB; rv:1.9.1b3pre) Gecko/20081204 Lightning/1.0pre Thunderbird/3.0b1

The icons on the mail toolbar should change (or be greyed out) when selecting the Calendar or Task tab, since many of them are irrelevant.

Reproducible: Always

Steps to Reproduce:
1.
2.
3.

Comment 1

[Dan Mosedale (:dmosedale, :dmose)]

Many of them are duplicates of functionality now available in the message header and are expected to go away (at least from the default set) for Tb3.  clarkbw may have some thoughts on whether this applies to the remaining buttons (or the ones that users explicitly add via "Customize".

Comment 2

[Magnus Melin [:mkmelin]]

Confirming. Not "in default set" doesn't mean it shouldn't work properly.

Comment 3

[Dan Mosedale (:dmosedale, :dmose)]

What's not yet clear is whether they should remain at all, or go away entirely.

Comment 4

[Bryan Clark (DevTools PM) [:clarkbw]]

I think we need an answer about upgrades (coming from tb 1 or 2) for people who use the message buttons in the toolbar.  I'm assuming that for people upgrading we'll need to keep the buttons around, though not necessarily in the default set.  I'm not certain that we want to remove them completely, at least from people with non-default toolbars.

The fact that the message buttons won't be in the default set of toolbar buttons (bug 474523) probably just affects the priority of making this change.

Comment 5

[Dan Mosedale (:dmosedale, :dmose)]

Blocking because this needs an explicit decision.  Someone should test to see exactly what the upgrade experience looks like (or will look like) once bug 474523 lands, and then make a proposal on what to do here and request ui-review.

Comment 6

[Dan Mosedale (:dmosedale, :dmose)]

Assigning to Gary for further investigation.

Comment 7

[Gary Kwong [:gkw] [:nth10sd] (NOT official MoCo now)]

(In reply to comment #5)
> Blocking because this needs an explicit decision.  Someone should test to see
> exactly what the upgrade experience looks like (or will look like) once bug
> 474523 lands, and then make a proposal on what to do here and request
> ui-review.

(In reply to comment #6)
> Assigning to Gary for further investigation.

Holding off till bug 474523 has some sort of patch to test..

Comment 8

[Bryan Clark (DevTools PM) [:clarkbw]]

cooked up attachment 364981 [details] [diff] [review] in bug 474523 with the patch you need

Comment 9

[Gary Kwong [:gkw] [:nth10sd] (NOT official MoCo now)]

(In reply to comment #8)
> cooked up attachment 364981 [details] [diff] [review] in bug 474523 with the patch you need

You mentioned that another real patch is coming up from:

https://bugzilla.mozilla.org/show_bug.cgi?id=474523#c6

Setting a depends on to keep track.

Comment 10

[Andrew Sutherland [:asuth] (he/him)]

Standard8 implemented per-tab command updater support, so this is fixed as far as Thunderbird is concerned.