Closed Bug 474766 Opened 12 years ago Closed 10 years ago

The [details] string is duplicated when replying to a comment containing a link to an attachment

Categories

(Bugzilla :: Creating/Changing Bugs, defect)

defect
Not set
trivial

Tracking

()

RESOLVED FIXED
Bugzilla 3.6

People

(Reporter: dennis.benn, Assigned: LpSolit)

References

Details

Attachments

(1 file)

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-GB; rv:1.9.0.2) Gecko/2008090514 Firefox/3.0.2
Build Identifier: 

If I reply to a comment which has a linked attachment the link to the detail page is doubled. It happens each time somebody replys to a comment with link to an attachment.

In the commentfield it looks like this:
> I like attachment 1 [details] [diff] [review]
Or after the second reply:
>> I like attachment 1 [details] [diff] [review] [details]

Reproducible: Always

Steps to Reproduce:
1. Write a comment with link to an attachment.
2. Reply to your own comment.
3. See the doubled [details] hint.
Whiteboard: DUPEME?
I pretty sure this is a duplicate, but I cannot find it. Marking as NEW.
Status: UNCONFIRMED → NEW
Ever confirmed: true
OS: Windows XP → All
Hardware: x86 → All
Whiteboard: DUPEME?
Duplicate of this bug: 561380
Attached patch patch, v1Splinter Review
Assignee: create-and-change → LpSolit
Status: NEW → ASSIGNED
Attachment #487073 - Flags: review?(mkanat)
Comment on attachment 487073 [details] [diff] [review]
patch, v1

Hmm, why the :? in the regex? Is there a situation where there will be a colon there?
Comment on attachment 487073 [details] [diff] [review]
patch, v1

I suspect that you meant ?: instead. If that's the case, then this looks fine, yeah, just fix that on checkin.
Attachment #487073 - Flags: review?(mkanat) → review+
Flags: approval4.0+
Flags: approval3.6+
Flags: approval+
Target Milestone: --- → Bugzilla 3.6
(In reply to comment #5)
> I suspect that you meant ?: instead. If that's the case, then this looks fine,
> yeah, just fix that on checkin.

Yeah, that's what I meant, sorry. :) The regexp was still working correctly, because $3 is ignored.
Committing to: bzr+ssh://lpsolit%40gmail.com@bzr.mozilla.org/bugzilla/trunk/
modified Bugzilla/Template.pm
Committed revision 7595.

Committing to: bzr+ssh://lpsolit%40gmail.com@bzr.mozilla.org/bugzilla/4.0/
modified Bugzilla/Template.pm
Committed revision 7475.

Committing to: bzr+ssh://lpsolit%40gmail.com@bzr.mozilla.org/bugzilla/3.6/
modified Bugzilla/Template.pm
Committed revision 7204.
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Summary: [details] field doubled if click on reply to a comment with link to an attachment → The [details] string is duplicated when replying to a comment containing a link to an attachment
You need to log in before you can comment on or make changes to this bug.