474766 - The [details] string is duplicated when replying to a comment containing a link to an attachment

Status: RESOLVED FIXED

(Bugzilla :: Creating/Changing Bugs, defect)

Description

[Dennis Benn]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-GB; rv:1.9.0.2) Gecko/2008090514 Firefox/3.0.2
Build Identifier: 

If I reply to a comment which has a linked attachment the link to the detail page is doubled. It happens each time somebody replys to a comment with link to an attachment.

In the commentfield it looks like this:
> I like attachment 1 [details] [diff] [review]
Or after the second reply:
>> I like attachment 1 [details] [diff] [review] [details]

Reproducible: Always

Steps to Reproduce:
1. Write a comment with link to an attachment.
2. Reply to your own comment.
3. See the doubled [details] hint.

Comment 1

[Frédéric Buclin]

I pretty sure this is a duplicate, but I cannot find it. Marking as NEW.

Comment 3

[Frédéric Buclin]

Attachment: patch, v1

Comment 4

[Max Kanat-Alexander]

Comment on attachment 487073 [details] [diff] [review]
patch, v1

Hmm, why the :? in the regex? Is there a situation where there will be a colon there?

Comment 5

[Max Kanat-Alexander]

Comment on attachment 487073 [details] [diff] [review]
patch, v1

I suspect that you meant ?: instead. If that's the case, then this looks fine, yeah, just fix that on checkin.

Comment 6

[Frédéric Buclin]

(In reply to comment #5)
> I suspect that you meant ?: instead. If that's the case, then this looks fine,
> yeah, just fix that on checkin.

Yeah, that's what I meant, sorry. :) The regexp was still working correctly, because $3 is ignored.

Comment 7

[Frédéric Buclin]

Committing to: bzr+ssh://[e-mail]/bugzilla/trunk/
modified Bugzilla/Template.pm
Committed revision 7595.

Committing to: bzr+ssh://[e-mail]/bugzilla/4.0/
modified Bugzilla/Template.pm
Committed revision 7475.

Committing to: bzr+ssh://[e-mail]/bugzilla/3.6/
modified Bugzilla/Template.pm
Committed revision 7204.