474813 - Fennec.exe needs an icon

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Brad Lassey [:blassey] (use needinfo?)]

Right now it has the default windows executable icon.

Comment 1

[Mark Finkle (:mfinkle) (use needinfo?)]

http://blogs.msdn.com/windowsmobile/archive/2006/06/07/621671.aspx has some guidelines for icon sizes

Bug 467825 will get a small tool into the tree we can use to stuff the ico into the stub

Comment 2

[Madhava Enros [:madhava]]

Attachment: ico files (xp and vista varieties) for fennec

try these out

Comment 3

[Mark Finkle (:mfinkle) (use needinfo?)]

Attachment: patch

This patch uses the redit.exe tool added in bug 467825 and adds the fennec icon (the 32x32 XP ico in attach 358283). After testing, the ico is added to the fennec.exe and is visible when running on Windows Mobile emulator.

I think the various sizes of ICOs need to be combined into a single ICO file to work in all situations.

Comment 4

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 358335 [details] [diff] [review]
patch

Shouldn't we be avoiding cp and instead using nsinstall, in general? Someone who knows the build system better than I do would probably make a better reviewer, but you can have my rubber stamp...

Comment 5

[Mark Finkle (:mfinkle) (use needinfo?)]

(In reply to comment #4)
> (From update of attachment 358335 [details] [diff] [review])
> Shouldn't we be avoiding cp and instead using nsinstall, in general? Someone
> who knows the build system better than I do would probably make a better
> reviewer, but you can have my rubber stamp...

I checked the m-c makefiles and it seems that | cp | is used for copying ICO files. The might be something with the way nsinstall copies that isn't good for binary image files (?).

Comment 6

[Mark Finkle (:mfinkle) (use needinfo?)]

Madhava - could you make a combined ICO file with all the sizes?

Also, could you add some PNG files too? I can use them for the Linux desktop build. Maybe an ICNS file too? These are not a priority, but might be nice to have.

Comment 7

[Mark Finkle (:mfinkle) (use needinfo?)]

http://hg.mozilla.org/mobile-browser/rev/c62b5a471707

we can add the newer icons later

Comment 8

[Joel Maher ( :jmaher ) (UTC -8)]

verified with alpha2 of winmo