Closed Bug 474825 Opened 12 years ago Closed 12 years ago

honor mozilla.widget.disable-native-theme preference

Categories

(Core :: Widget: Win32, defect)

x86
macOS
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla1.9.2a1

People

(Reporter: dougt, Assigned: dougt)

References

Details

(Keywords: fixed1.9.1)

Attachments

(2 files)

we can gain a performance improvement if we disable native themes on windows similar to what we saw on GTK2.
Attached patch patch v.1Splinter Review
Comment on attachment 358243 [details] [diff] [review]
patch v.1

please ignore the cairo patch (even though it is probabl the right thing).
Attachment #358243 - Flags: review?(pavlov)
Flags: wanted1.9.1?
Attachment #358243 - Flags: review?(pavlov) → review+
Flags: wanted1.9.1? → wanted1.9.1+
http://hg.mozilla.org/mozilla-central/rev/da96b60d822e
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
The previous patch was incorrect; it added a constructor that checked the pref, but that constructor was never called.  There's already an existing win32 NS_NewNativeTheme constructor (which was what the component entry was calling), so the check just moved into there.
Attachment #362378 - Flags: review?
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Attachment #362378 - Flags: review?(pavlov) → review+
http://hg.mozilla.org/mozilla-central/rev/a6a7dac9155a
http://hg.mozilla.org/releases/mozilla-1.9.1/rev/20033256426a
Status: REOPENED → RESOLVED
Closed: 12 years ago12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.2a1
You need to log in before you can comment on or make changes to this bug.