474825 - honor mozilla.widget.disable-native-theme preference

Status: RESOLVED FIXED

(Core :: Widget: Win32, defect)

Description

[Doug Turner (:dougt)]

we can gain a performance improvement if we disable native themes on windows similar to what we saw on GTK2.

Comment 1

[Doug Turner (:dougt)]

Attachment: patch v.1

Comment 2

[Doug Turner (:dougt)]

Comment on attachment 358243 [details] [diff] [review]
patch v.1

please ignore the cairo patch (even though it is probabl the right thing).

Comment 3

[Doug Turner (:dougt)]

http://hg.mozilla.org/mozilla-central/rev/da96b60d822e

Comment 4

[Doug Turner (:dougt)]

http://hg.mozilla.org/releases/mozilla-1.9.1/rev/a7858cfcb2ee

Comment 5

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Attachment: really disable it

The previous patch was incorrect; it added a constructor that checked the pref, but that constructor was never called.  There's already an existing win32 NS_NewNativeTheme constructor (which was what the component entry was calling), so the check just moved into there.

Comment 6

[Doug Turner (:dougt)]

http://hg.mozilla.org/mozilla-central/rev/a6a7dac9155a
http://hg.mozilla.org/releases/mozilla-1.9.1/rev/20033256426a