475027 - cross-compiling to mingw broken

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Benjamin Smedberg]

Neil indicated that cross-compiling to mingw was broken by bug 269538. I don't have a mingw-cross environment to check with, but here are some thoughts and theories:

1) are you hitting this block in js/src/configure.in at all? http://mxr.mozilla.org/mozilla-central/source/js/src/configure.in#2556

If not, we need to figure out why: only MSVC should be setting SKIP_COMPILER_CHECKS, here: http://mxr.mozilla.org/mozilla-central/source/js/src/configure.in#571

2) The CROSS_COMPILE check in jstypes.h is silly. We should just check for MSC_VER and otherwise use jsautocfg.h. I'll attach a patch shortly.

Comment 1

[Benjamin Smedberg]

Attachment: Make inclusion of jscpucfg.h/jsautocfg.h more sane, rev. 1

Comment 2

[Jim Blandy :jimb]

Comment on attachment 358422 [details] [diff] [review]
Make inclusion of jscpucfg.h/jsautocfg.h more sane, rev. 1

You could change the comment on the #inclusion of jscpucfg.h not to mention Mac.

Comment 3

[Benjamin Smedberg]

Attachment: Special-case MSVC only, rev. 1

What Neil is actually doing is cross-compiling from FreeBSD->Windows using *MSVC* via Wine. This patch makes it so that we only use jscpucfg.h for MSVC, and use jsautocfg.h in all other configurations.

Comment 4

[Benjamin Smedberg]

http://hg.mozilla.org/mozilla-central/rev/b4ddaaf84af5

Comment 5

[Benjamin Smedberg]

http://hg.mozilla.org/releases/mozilla-1.9.1/rev/558f032401e5

Pushed to 1.9.1 as a part of the sequence of patches for bug 470071