475225 - Add JPEG optimization for x86_64 platform

Status: RESOLVED WORKSFORME

(Core :: Graphics: ImageLib, defect)

Description

[Makoto Kato [:m_kato]]

Currently, JPEG SSE2 code is only Windows x86.  I will add it for x86_64 platform.

After adding it, JPEG decoding is 15% faster.

Comment 1

[Makoto Kato [:m_kato]]

Attachment: patch v1

tested on Windows x64 and Ubuntu 8.10 x86_64.

After testing CentOS 5.2, I will send a review.

Comment 2

[Michael Moy]

I'm working on a bug with the Intel SSE2 code right now (it also exists with the MMX code) so it might be worthwhile to hold off on this. There isn't a bugzilla entry for this yet (to my knowledge) but I'll enter one if the reporter doesn't do so soon. I'm assuming that this code was derived from the Intel code.

Comment 3

[Joe Drew (not getting mail)]

Comment on attachment 359419 [details] [diff] [review]
patch v1

Jeff, you have looked at Michael's SSE work in bug 477728 - you should look at this too. :)

Comment 4

[Jeff Muizelaar [:jrmuizel]]

Comment on attachment 359419 [details] [diff] [review]
patch v1

I think we want to port the code in bug 477728 instead of the existing code.

Comment 5

[Ashu]

Did the work on libjpeg-turbo make this bug obsolete?

Comment 6

[Makoto Kato [:m_kato]]

(In reply to comment #5)
> Did the work on libjpeg-turbo make this bug obsolete?

Oh, Yes.  bug 646704 is landed, so this should be fixed.