Closed Bug 646704 Opened 9 years ago Closed 9 years ago

cannot build Win64 package after landing libjpeg-turbo

Categories

(Core :: ImageLib, defect)

x86_64
Windows Vista
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla5

People

(Reporter: m_kato, Assigned: m_kato)

References

Details

Attachments

(1 file)

need -DMSVC
Attached patch fixSplinter Review
need MSVC define (see jsimdext.inc)
Attachment #523198 - Flags: review?(justin.lebar+bug)
Comment on attachment 523198 [details] [diff] [review]
fix

r=me if that fixes it.

Do you know why -DMSVC isn't needed for Windows x86?
Attachment #523198 - Flags: review?(justin.lebar+bug) → review+
(In reply to comment #2)

> Do you know why -DMSVC isn't needed for Windows x86?

default ABI is different. x86 default is stdcall.  (need "_" prefix)
Keywords: checkin-needed
(In reply to comment #5)
> What stopping us from landing a patch ?

nothing to best of my knowledge just no one has uploaded it
(In reply to comment #7)
> So what's that then ;)
> https://bugzilla.mozilla.org/attachment.cgi?id=523198

i meant upload it to build machine silly the bugs flagged as checkin needed just a question of when will devs upload to build machine
All of MoCo is currently out of town and without reliable Internet connections.  I'll land this ASAP, but it won't be until tomorrow at the earliest.
http://hg.mozilla.org/projects/cedar/rev/1bed280a1575
Keywords: checkin-needed
Whiteboard: fixed-in-cedar
Target Milestone: --- → mozilla2.2
http://hg.mozilla.org/mozilla-central/rev/1bed280a1575
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Whiteboard: fixed-in-cedar
Odd, I still not see any new 64bit builds after landing this patch. Any ideas what's going on ?
(In reply to comment #13)
> Odd, I still not see any new 64bit builds after landing this patch. Any ideas
> what's going on ?

my guess is that there may be more then one bug preventing it from building probably when they had such a huge backlog of patches that landed on ceder (ceder is only bulding 32 bit to best of my knowlodge) your best bet is to file new bug and link to this one
(In reply to comment #13)
> Odd, I still not see any new 64bit builds after landing this patch. Any ideas
> what's going on ?

It won't be fixed until current tracemonkey is merged into mozilla-central.  PGO build will crash by method-jit bug.
Note regarding the MSVC NASM %define:  it is no longer necessary to define MSVC in the latest libjpeg-turbo subversion code.  The reason for that %define was that MinGW64 and Visual C++ did not use the same symbol naming conventions when building Win64 code.  MinGW64 used to enable -fno-leading-underscore by default, which mimicked the behavior of 32-bit MinGW.  With 1.0, however, MinGW64 has adopted the behavior of Visual C++ 64-bit (it sets -fleading-underscore by default), so we now assume this behavior in libjpeg-turbo.
You need to log in before you can comment on or make changes to this bug.