475377 - [silme] Potential performance boost in silme.core.entity

Status: NEW

(Localization Infrastructure and Tools :: Silme, defect)

Description

[Zibi Braniecki [:zbraniecki][:gandalf]]

Attachment: patch against rev. 306

There are at least two low hanging fruits regarding performance in silme.core.entity.

First one is to split silme.core.Entity into SimpleEntity and ComplexEntity. Both should have the same API, ComplexEntity will be what Entity is now, while SimpleEntity will ignore multilocale.

The rationale for this is that in many Mozilla scripts we do not use multilocale so checking and selecting locale codes in this case has no value.

I'm not checking it in yet because first tests on my compare-locales from ./scripts did not show as major boost (1.3sec vs. 1.15sec) as I expected.

It's definitely worth keeping an eye on and implementing if we'll see a reason.

Second is adding silme.core.EntityList.sort boolean which will enable/disable sorting of entities in EntityList.
It makes sense to sort entities in EntityList for purposes such as webapp, but it is not important in compare-locales.

Turning off sorting speeds up silme.core.EntityList.add_entity which is superbusy method in all compare-* scripts.

Unfortunately, as with previous one, early tests shows little boost - 1.3sec vs. 1.25sec.

Comment 1

[Zibi Braniecki [:zbraniecki][:gandalf]]

Oh, btw. part of this has actually landed:
http://hg.mozilla.org/users/zbraniecki_mozilla.com/silme/rev/a74bd64a00e2

So EntityList can now be sorted or unsorted (faster).

Comment 2

[Francesco Lodolo [:flod]]

Moving Silme bugs to its component.

[Mass change filter: silme-move]