Closed Bug 475482 Opened 17 years ago Closed 17 years ago

addons can set new folderpane modes, causing breakage if not reset

Categories

(Thunderbird :: Folder and Message Lists, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 3.0b3

People

(Reporter: davida, Assigned: rkent)

Details

Attachments

(2 files, 1 obsolete file)

Something i noticed when playing w/ new folderpane modes -- if you start tb w/ an addon (or a patch such as that in bug 305340) which defines a new folderpane mode, switch to it, and quit, that folder pane mode is persisted (good). If you start a version of Tb that doesn't support the new folderpane mode (e.g an older one), or a version of tb w/o the addon in question, then the folder pane fails pretty spectacularly. It'd be good to put some try/catch code around the folderpane mode setting, and reset to the All Folders default if there's a problem (with an error dialog maybe). In general I suspect the addons should reset the folderpane on uninstall, but I doubt many will. jminta, your thoughts?
Flags: wanted-thunderbird3+
Sounds pretty bad to me if safe-mode doesn't bring you back to the vanilla view.
Flags: blocking-thunderbird3+
Target Milestone: --- → Thunderbird 3.0b3
Reassigning to Joey, in the hopes that he'll have the bandwidth to take a look at it.
Component: Mail Window Front End → Folder and Message Lists
QA Contact: front-end → folders-message-lists
Assignee: nobody → jminta
Flags: wanted-thunderbird3+
Attached patch add the try block in get mode (obsolete) — — Splinter Review
This looks pretty trivial, so let me move this forward.
Assignee: jminta → kent
Status: NEW → ASSIGNED
Attachment #371721 - Flags: review?(jminta)
This patch is a de-bit rotted version of bienvenu's patch, mentioned by davida as demonstrating the problem. If you load that patch, select Smart Folders mode, exit, and unload the patch, upon restart the folder pane will be blank without my patch.
Comment on attachment 371721 [details] [diff] [review] add the try block in get mode if (!this._mode) + { Style for this file is to keep braces on the same line. + // this can happen when an extension is removed + if (!this._mapGenerators[this._mode]) I think semantically !(this._mode in this._mapGenerators) is more accurate. r=jminta with that.
Attachment #371721 - Flags: review?(jminta) → review+
Carrying over r from jminta
Attachment #371721 - Attachment is obsolete: true
Attachment #371736 - Flags: review+
Keywords: checkin-needed
Status: ASSIGNED → RESOLVED
Closed: 17 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: