Closed
Bug 475482
Opened 17 years ago
Closed 17 years ago
addons can set new folderpane modes, causing breakage if not reset
Categories
(Thunderbird :: Folder and Message Lists, defect)
Thunderbird
Folder and Message Lists
Tracking
(Not tracked)
RESOLVED
FIXED
Thunderbird 3.0b3
People
(Reporter: davida, Assigned: rkent)
Details
Attachments
(2 files, 1 obsolete file)
|
12.34 KB,
patch
|
Details | Diff | Splinter Review | |
|
536 bytes,
patch
|
rkent
:
review+
|
Details | Diff | Splinter Review |
Something i noticed when playing w/ new folderpane modes -- if you start tb w/ an addon (or a patch such as that in bug 305340) which defines a new folderpane mode, switch to it, and quit, that folder pane mode is persisted (good).
If you start a version of Tb that doesn't support the new folderpane mode (e.g an older one), or a version of tb w/o the addon in question, then the folder pane fails pretty spectacularly. It'd be good to put some try/catch code around the folderpane mode setting, and reset to the All Folders default if there's a problem (with an error dialog maybe).
In general I suspect the addons should reset the folderpane on uninstall, but I doubt many will.
jminta, your thoughts?
Flags: wanted-thunderbird3+
Comment 1•17 years ago
|
||
Sounds pretty bad to me if safe-mode doesn't bring you back to the vanilla view.
Flags: blocking-thunderbird3+
Target Milestone: --- → Thunderbird 3.0b3
Comment 2•17 years ago
|
||
Reassigning to Joey, in the hopes that he'll have the bandwidth to take a look at it.
Component: Mail Window Front End → Folder and Message Lists
QA Contact: front-end → folders-message-lists
Updated•17 years ago
|
Assignee: nobody → jminta
Updated•17 years ago
|
Flags: wanted-thunderbird3+
| Assignee | ||
Comment 3•17 years ago
|
||
This looks pretty trivial, so let me move this forward.
| Assignee | ||
Comment 4•17 years ago
|
||
This patch is a de-bit rotted version of bienvenu's patch, mentioned by davida as demonstrating the problem. If you load that patch, select Smart Folders mode, exit, and unload the patch, upon restart the folder pane will be blank without my patch.
Comment 5•17 years ago
|
||
Comment on attachment 371721 [details] [diff] [review]
add the try block in get mode
if (!this._mode)
+ {
Style for this file is to keep braces on the same line.
+ // this can happen when an extension is removed
+ if (!this._mapGenerators[this._mode])
I think semantically !(this._mode in this._mapGenerators) is more accurate.
r=jminta with that.
Attachment #371721 -
Flags: review?(jminta) → review+
| Assignee | ||
Comment 6•17 years ago
|
||
Carrying over r from jminta
Attachment #371721 -
Attachment is obsolete: true
Attachment #371736 -
Flags: review+
| Assignee | ||
Updated•17 years ago
|
Keywords: checkin-needed
Comment 7•17 years ago
|
||
You need to log in
before you can comment on or make changes to this bug.
Description
•