475502 - gloda's concept of 'me' should listen for account addition

Status: NEW

(MailNews Core :: Database, defect)

Description

[Andrew Sutherland [:asuth] (he/him)]

Gloda._initMyIdentities builds up a concept of the user's own identity at startup.  It doesn't do anything when the user adds new accounts until they restart.  We arguably should handle the common use case of the user adding an account and then gloda going to town on it.

I had previously thought we should handle modifications and removals as well, but I'm not sure what there is to do about removals; we probably do not want to forget about the user's old accounts from an identity perspective.  For modifications we do want to pick up changes in e-mail address, although we might theoretically want to try and prune anything that was clearly a typo (edit distance analysis?).

Comment 1

[Dan Mosedale (:dmosedale, :dmose)]

I'd go further than "arguably".  However, I don't think this quite rises to the level of a blocker, so marking as wanted+.

Agreed that we don't want to completely forget on removal (maybe just marked disabled?; I remember having the same email address for two summer internships during college, with it disabled in between).  Being robust about typos via edit distance seems like something reasonable to think about, but probably a candidate to spun off into another bug.

Comment 2

[Wayne Mery (:wsmwk)]

Do we have any reason to believe that this condition still exists?
Because I am unable to reproduce ludo's bug 528913

Comment 3

[Andrew Sutherland [:asuth] (he/him)]

I just did a quick skim, we never implemented this.  Note that I think Ludo's STR includes starting from 0 accounts in the profile.  It wouldn't be surprising if we made things more resilient so we don't break in that case, but this bug still stands.